Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use available RoleHierachy Bean for MethodSecurity Config #14260

Merged
merged 2 commits into from
Dec 7, 2023
Merged

Use available RoleHierachy Bean for MethodSecurity Config #14260

merged 2 commits into from
Dec 7, 2023

Conversation

DerChris173
Copy link
Contributor

Forked and reworked from #14057

Closes #12783

PR includes

Automatic inclusion of any RoleHierarchy Bean into the Configurations related to Method Security

@pivotal-cla
Copy link

@DerChris173 Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-cla
Copy link

@DerChris173 Thank you for signing the Contributor License Agreement!

@DerChris173 DerChris173 mentioned this pull request Dec 7, 2023
Closed
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Dec 7, 2023
@jzheaux
Copy link
Contributor

jzheaux commented Dec 7, 2023

Thanks for the PR, @DerChris173. Will you please ./gradlew format and then push again? Also, in preparation for merging, will you please squash your commits, but leave @kandaguru17's as a separate commit?

For polish commits messages, we usually use Issue as follows:

Polish RoleHierarchy Bean Usage

Issue gh-12783

@DerChris173
Copy link
Contributor Author

Thanks @jzheaux , will take care and do as you suggest

@DerChris173
Copy link
Contributor Author

Updated the branch.

@jzheaux jzheaux merged commit e6bea1c into spring-projects:main Dec 7, 2023
2 checks passed
@jzheaux jzheaux added status: duplicate A duplicate of another issue in: config An issue in spring-security-config type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Dec 7, 2023
@jzheaux jzheaux added this to the 6.3.0-M1 milestone Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jzheaux jzheaux

Labels
in: config An issue in spring-security-config status: duplicate A duplicate of another issue type: enhancement A general enhancement
Projects
Spring Security Team
Status: Done
Milestone
6.3.0-M1
Development

Successfully merging this pull request may close these issues.

Use RoleHierarchy bean in Method Security Configuration
5 participants
@DerChris173 @pivotal-cla @jzheaux @spring-projects-issues @kandaguru17