-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement customization of rolePrefix
in LdapUserDetailsManager
#14574
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @Haarolean! In addition to the inline feedback, will you please add some tests to LdapUserDetailsManagerTests
for the new feature? And, will you please squash and format any commits into a single commit like so:
Commit Title (for example, Add Customization of rolePrefix in LdapUserDetailsManager)
Closes gh-2083
(quite similar to what you have already, just shortening the title and adding the Closes
phrase to the description)
ldap/src/main/java/org/springframework/security/ldap/userdetails/LdapUserDetailsManager.java
Show resolved
Hide resolved
Hi, @Haarolean, are you able to make the requested changes? I'm happy to help, if not. |
Hey, sure am! Been busy a bit lately, will push the changes today. |
@jzheaux do we have any instructions on how to enable checkstyle properly? Having a hard time with checkstyle (as always) in spring projects, I've imported the |
ddfb9c5
to
ca43063
Compare
Thanks again, @Haarolean! This is now merged into |
@jzheaux thank you! Didn't know about the header part. |
Resolves #2083