Expose user name attribute name in OAuth2UserAuthority
#15012
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
|
Can someone from the Spring Security team have a look at this? If this is something that you are not interested in then let me know and we can close it. |
sjohnr
added
type: enhancement
|
Thanks @filiphr! I'll be taking a look at this and send any feedback in the next few days. Overall it seems reasonable and a nice enhancement so I think we should be able to accept it. |
|
Thanks a lot for merging this @sjohnr |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are using custom
GrantedAuthoritiesMapperthat is doing some custom loading of attributes based on theOAuth2UserAuthority. We've had some request to do something based on the user name. Currently, there is no easy way to access the configured username attribute name.The goal of this PR is to expose this information directly in the
OAuth2UserAuthorityand this make it easy to get the username from the attributes.An alternative could also be to expose
getUserNameand just use theuserNameAttributeNamein theOAuth2UserAuthority.I hope that you'll consider this PR, if there is anything that you think should be added or done better please let me know