Inline CSS for default login and logout page #15303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove the dependency on Bootstrap CSS. Results in faster load times, no failures in air-gapped or offline scenarios, and no dependency on an external CDN that may go away some day.
spring-projects-issues
added
the
status: waiting-for-triage
sjohnr
added
in: web
rwinch
approved these changes
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inline CSS for default login/logout pages
Context: gh-15302
Remove the dependency on Bootstrap CSS. Results in faster load times, no failures in air-gapped or offline scenarios, and no dependency on an external CDN that may go away some day.
Open questions / feedback / changes
Design details
Goals:
Anti-goals:
Performance and accessibility benchmarks
Using Chrome's embedded Lighthouse test suites, configured for mobile.
This implementation shows stable performance, accessibility and best practices scores.
The time to First Contentful Paint improves a lot, and drops from 1.5s to 0.7s.
Before / after HTML pages:
If you want to see the HTML pages live, and check their usage in a browser, I have an export of the pages available ; those are not running Spring Boot apps but rather an HTML export.
Before / after screenshots:
Login page:
Login page, with error:
Login page, with logout message:
Logout page:
Login page in a "phone emulator":