Preserve custom user type in InMemoryUserDetailsManager #15498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
jzheaux
changed the title
jzheaux
requested changes
Jul 29, 2024
There was a problem hiding this comment.
Thanks, @MrJovanovic13, for the PR! I've left some feedback inline.
...src/test/java/org/springframework/security/provisioning/InMemoryUserDetailsManagerTests.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/springframework/security/provisioning/InMemoryUserDetailsManager.java
Show resolved
Hide resolved
...src/test/java/org/springframework/security/provisioning/InMemoryUserDetailsManagerTests.java
Show resolved
Hide resolved
jzheaux
added
in: core
Tests added: createUserWhenUserAlreadyExistsThenException updateUserWhenUserDoesNotExistThenException loadUserByUsernameWhenUserNullThenException Issue spring-projectsgh-3192
jzheaux
approved these changes
Aug 9, 2024
|
Thanks again, @MrJovanovic13! This is now merged into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issue gh-3192 by allowing
MutableUserDetailsto be stored and loaded inside theInMemoryUserDetailsManagerinstead of always wrapping it intoMutableUser. The custom user type must implementCredentialsContainerin order to be returned byloadUserByUsername()and not transformed intoUser.I wanted to write tests for the new cases, and I saw that methods were not previously covered so I wrote tests for all cases for
createUser()andloadUserByUsername(). However, I have concerns about some tests:createUserWhenNotInstanceOfMutableUserDetailsThenShouldWrapIntoMutableUserandcreateUserWhenInstanceOfMutableUserDetailsThenShouldNotWrapIntoMutableUsercan't directly accessMap<String, MutableUserDetails> usersto get the underlying user & type, so they are relying onloadUserByUsernameto get the user and as such are not pure.If you think this can be improved somehow, I am open to feedback.