-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cookie customizer to CookieRequestCache #15685
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @fb64. I've left a single feedback inline.
Would you please add the same support in CookieServerRequestCache
? I believe that the only difference is that the cookieCustomizer
would be a Consumer<ResponseCookie.Builder>
web/src/main/java/org/springframework/security/web/savedrequest/CookieRequestCache.java
Show resolved
Hide resolved
As far as I know |
Hi @fb64, I'm sorry if what I said was confusing. But I mean that the reactive implementation should use a |
Got it, I added it to |
Thanks @fb64, this is now merged into |
Issue #15204