SEC-1900: Fixed by removing dependency to equals method in SimpleGrantedAuthority #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nstead of comparing any given implementation of GrantedAuthority with SimpleGrantedAuthority. I.e. the ifAllGranted code is no longer dependent on the implementation of the equals method in SimpleGrantedAuthorization.
|
Thank you for the pull request. I realize this patch was probably attempting to make as few changes as possible. However, I would prefer to not have unnecessary conversions as done in the submitted patch. Therefore I have pushed a modified version of your pull request. |
|
Thanks! |
This was referenced Feb 5, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made the role comparision be performed on sets of (role) strings instead of comparing any given implementation of GrantedAuthority with SimpleGrantedAuthority. I.e. the ifAllGranted code is no longer dependent on the implementation of the equals method in SimpleGrantedAuthorization.