SessionRegistryImpl is now aware of SessionIdChangedEvent #5439
Conversation
|
@aj-jaswanth Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@aj-jaswanth Thank you for signing the Contributor License Agreement! |
spring-projects-issues
added
the
status: waiting-for-triage
There was a problem hiding this comment.
@aj-jaswanth I realize this is an old PR, but I have added some comments inline if you are still interested in having it merged.
Furthermore, can you explain how to reproduce the case where SessionRegistryImpl will not be aware of the session ID change and continues to have the older sessionID.
| @@ -40,7 +41,7 @@ | |||
| * @author Luke Taylor | |||
| */ | |||
| public class SessionRegistryImpl implements SessionRegistry, | |||
| ApplicationListener<SessionDestroyedEvent> { | |||
| ApplicationListener<ApplicationEvent> { | |||
There was a problem hiding this comment.
ApplicationEvent may be too generic to be used in this class. Perhaps we can create a new interface (e.g SessionEvent) that both SessionDestroyedEvent and SessionIdChangedEvent can implement.
| @@ -0,0 +1,48 @@ | |||
| /* | |||
| * Copyright 2004, 2005, 2006 Acegi Technology Pty Limited | |||
There was a problem hiding this comment.
Please use the new license header for new classes.
| */ | ||
| public class HttpSessionIdChangedEvent extends SessionIdChangedEvent { | ||
| private final String oldSessionId; | ||
| private final String newSessionid; |
There was a problem hiding this comment.
There is a small typo here, newSessionid should be newSessionId.
eleftherias
added
in: config
eleftherias
added
type: enhancement
ghost
mentioned this pull request
Fixes #5438