Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused dependency slf4j-api in javaconfig x509 sample application #6131

Closed
wants to merge 1 commit into from

Conversation

raphaelDL
Copy link
Contributor

@raphaelDL raphaelDL commented Nov 23, 2018

This commit ensures that unused dependencies are not imported, that will prevent warning messages being thrown when building the project.

Fixes: gh-6130

This commit removes explicit declaration of slf4j dependencies.
Instead, logback classic is declared that will pull them transitively.

Fixes: spring-projectsgh-6130
@jgrandja jgrandja self-assigned this Nov 23, 2018
@jgrandja jgrandja added status: duplicate A duplicate of another issue Samples type: enhancement A general enhancement labels Nov 23, 2018
@jgrandja jgrandja added this to the 5.2.0.M1 milestone Nov 23, 2018
@jgrandja
Copy link
Contributor

Thanks for the PR @raphaelDL. This is now in master.

@jgrandja jgrandja closed this Nov 23, 2018
@rwinch rwinch added in: docs An issue in Documentation or samples and removed in: docs An issue in Documentation or samples labels May 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: docs An issue in Documentation or samples status: duplicate A duplicate of another issue type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove unused compile dependency in javaconfig x509 sample
3 participants