Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Gradle 5.0 #6197

Merged
merged 1 commit into from
Nov 30, 2018
Merged

Update to Gradle 5.0 #6197

merged 1 commit into from
Nov 30, 2018

Conversation

dbuos
Copy link
Contributor

@dbuos dbuos commented Nov 30, 2018

Change project's gradle version to 5.0, this requires to make some minor
adjustments.

Fixes: gh-6148

Change project's gradle version to 5.0, this requires to make some minor
adjustments.

Fixes: spring-projectsgh-6148
@pivotal-issuemaster
Copy link

@dbuos Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-issuemaster
Copy link

@dbuos Thank you for signing the Contributor License Agreement!

@rwinch rwinch self-assigned this Nov 30, 2018
@rwinch rwinch added status: duplicate A duplicate of another issue in: build An issue in the build type: enhancement A general enhancement labels Nov 30, 2018
@rwinch rwinch added this to the 5.2.0.M1 milestone Nov 30, 2018
@rwinch rwinch merged commit 6bddb38 into spring-projects:master Nov 30, 2018
@rwinch
Copy link
Member

rwinch commented Nov 30, 2018

Thanks for the PR @dbuos! This is now merged into master!

@dbuos dbuos deleted the gh-6148 branch November 30, 2018 14:53
@raphaelDL
Copy link
Contributor

I'm trying to build the project locally and sometimes I get the java out of memory exception, I'm not sure if this has something to do. I see that there's a memory limit set

I took a look at: https://docs.gradle.org/5.0/userguide/upgrading_version_4.html#rel5.0:default_memory_settings

when running: ./gradlew clean build integrationTest

I've got messages like:

Execution failed for task 
Java heap space

and

Expiring Daemon because JVM Tenured space is exhausted
Daemon will be stopped at the end of the build after running out of JVM memory

I don't know, what do you guys think? did it happen to you?

@rwinch
Copy link
Member

rwinch commented Dec 1, 2018

@raphaelDL Thanks for reaching out. I wonder if there is a memory leak somewhere. If you use the --no-daemon does it ever run out of memory?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: build An issue in the build status: duplicate A duplicate of another issue type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to Gradle 5.0
4 participants