Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RoleVoter Configuration Defaults Prefix Using GrantedAuthorityDefauts #6241

Merged
merged 1 commit into from
Dec 7, 2018
Merged

RoleVoter Configuration Defaults Prefix Using GrantedAuthorityDefauts #6241

merged 1 commit into from
Dec 7, 2018

Conversation

dongmyo
Copy link
Contributor

@dongmyo dongmyo commented Dec 6, 2018 •
edited by rwinch
Loading

RoleVoter Configuration Defaults Prefix Using GrantedAuthorityDefauts

Fixes: gh-4876

@rwinch rwinch changed the title fix RoleVoter rolePrefix issue RoleVoter Configuration Defaults Prefix Using GrantedAuthorityDefauts Dec 6, 2018
rwinch
rwinch requested changes Dec 6, 2018
View reviewed changes
Copy link
Member

@rwinch rwinch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @dongmyo!

Could you please change the first line of your commit to be a bit more descriptive? Perhaps RoleVoter Configuration Defaults Prefix Using GrantedAuthorityDefauts

Thanks again for the PR!

@dongmyo
Copy link
Contributor Author

dongmyo commented Dec 7, 2018

@rwinch i changed the commit message.

@rwinch rwinch self-assigned this Dec 7, 2018
@rwinch rwinch added in: config An issue in spring-security-config type: enhancement A general enhancement labels Dec 7, 2018
@rwinch rwinch added this to the 5.2.0.M1 milestone Dec 7, 2018
@rwinch rwinch merged commit 56eb658 into spring-projects:master Dec 7, 2018
@rwinch
Copy link
Member

rwinch commented Dec 7, 2018

Thanks @dongmyo! This is now merged into master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwinch rwinch rwinch approved these changes

Assignees

@rwinch rwinch

Labels
in: config An issue in spring-security-config type: enhancement A general enhancement
Projects
None yet
Milestone
5.2.0.M1
Development

Successfully merging this pull request may close these issues.

RoleVoter Configuration Defaults Prefix Using GrantedAuthorityDefauts
2 participants
@dongmyo @rwinch