Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Anonymous Support to AuthenticatedReactiveAuthorizationManager #6267

Merged
merged 1 commit into from
Dec 12, 2018

Conversation

mibo
Copy link
Contributor

@mibo mibo commented Dec 10, 2018

Fixes: gh-6235

@rwinch rwinch self-assigned this Dec 11, 2018
@rwinch rwinch added this to the 5.2.0.M1 milestone Dec 11, 2018
@rwinch rwinch added in: core An issue in spring-security-core Reactive type: enhancement A general enhancement labels Dec 11, 2018
@rwinch
Copy link
Member

rwinch commented Dec 11, 2018

Thanks for the PR @mibo!

Can you please update the commit message to align with the Spring Security conventions?

Something like

Add Anonymous Support to AuthenticatedReactiveAuthorizationManager

Fixes: gh-6235

@rwinch rwinch added the status: waiting-for-feedback We need additional information before we can continue label Dec 11, 2018
@mibo
Copy link
Contributor Author

mibo commented Dec 12, 2018

@rwinch I changed the commit message accordingly (and remember it for next time 😄 ).

Hope the way with the forced-push is fine in this case.

Regards, Michael

@rwinch rwinch removed the status: waiting-for-feedback We need additional information before we can continue label Dec 12, 2018
@rwinch rwinch changed the title Added check for not anonymous; resolve #6235 Add Anonymous Support to AuthenticatedReactiveAuthorizationManager Dec 12, 2018
@rwinch rwinch added the status: duplicate A duplicate of another issue label Dec 12, 2018
@rwinch rwinch merged commit 60e3bf4 into spring-projects:master Dec 12, 2018
@rwinch
Copy link
Member

rwinch commented Dec 12, 2018

Thanks @mibo! This is now merged into master

Hope the way with the forced-push is fine in this case.

Yes. It is your branch so a force push is expected in this case.

Thanks again for contributing to Spring Security! We hope to see additional contributions from you soon!

@mibo
Copy link
Contributor Author

mibo commented Dec 13, 2018

Thanks again for contributing to Spring Security! We hope to see additional contributions from you soon!

Yes, will do my best to do more contributions ;o)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: core An issue in spring-security-core status: duplicate A duplicate of another issue type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants