Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WebFlux support for spring security web jackson module. #6305

Merged
merged 1 commit into from
Dec 19, 2018

Conversation

finke-ba
Copy link
Contributor

Linked with #6293

Fixes #6303

@rwinch
Copy link
Member

rwinch commented Dec 18, 2018

@finke-ba Do you mind performing a rebase on this please?

@rwinch rwinch added the status: waiting-for-feedback We need additional information before we can continue label Dec 18, 2018
@rwinch rwinch self-assigned this Dec 18, 2018
@finke-ba
Copy link
Contributor Author

finke-ba commented Dec 18, 2018

@rwinch What do you mean? Merge master into gh-6303 and make rebase after that?

@finke-ba
Copy link
Contributor Author

@rwinch hello, I hope I did it right. Could you please check it?

Copy link
Member

@rwinch rwinch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@finke-ba Thanks! This is just what I wanted in terms of a rebase.

Can you please update the commit message to align with the Spring Security conventions? Specifically, can you please update your commit to include Fixes: gh-6303 at the end

@finke-ba
Copy link
Contributor Author

@rwinch sure, I'll add. But I also didn't do it for #6304 which is already merged into master..

@finke-ba
Copy link
Contributor Author

@rwinch, done!

@rwinch rwinch added type: enhancement A general enhancement Reactive and removed status: waiting-for-feedback We need additional information before we can continue labels Dec 19, 2018
@rwinch rwinch added this to the 5.2.0.M1 milestone Dec 19, 2018
@rwinch rwinch merged commit b838f7c into spring-projects:master Dec 19, 2018
@rwinch
Copy link
Member

rwinch commented Dec 19, 2018

But I also didn't do it for #6304 which is already merged into master..

Thanks for the heads up. I noticed this but it is too late. It isn't the end of the world though.

done!

Thanks for yet another contribution! You are on fire! This is now merged into master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: duplicate A duplicate of another issue type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants