Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML markup fixed in DefaultLoginPageGeneratingFilter #6448

Merged
merged 1 commit into from
Jan 22, 2019

Conversation

ankurpathak
Copy link
Contributor

@ankurpathak ankurpathak commented Jan 17, 2019

Ending div moved out of condition.

Fixes: gh-6417

@ankurpathak
Copy link
Contributor Author

Pull request for issue:
#6417

Copy link
Member

@rwinch rwinch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Can you please correct the commit message to be Fixes:?

@ankurpathak
Copy link
Contributor Author

Thanks for the PR! Can you please correct the commit message to be Fixes:?

Fixed commit message Typo.

@rwinch rwinch self-assigned this Jan 22, 2019
@rwinch rwinch added in: web An issue in web modules (web, webmvc) type: bug A general bug labels Jan 22, 2019
@rwinch rwinch added this to the 5.2.0.M2 milestone Jan 22, 2019
@rwinch rwinch merged commit ffe602f into spring-projects:master Jan 22, 2019
@rwinch rwinch added the status: duplicate A duplicate of another issue label Jan 22, 2019
@rwinch
Copy link
Member

rwinch commented Jan 22, 2019

Thanks for the quick fix @ankurpathak! This is now merged into master and backported via gh-6468

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: web An issue in web modules (web, webmvc) status: duplicate A duplicate of another issue type: bug A general bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants