Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve CsrfBeanDefinitionParser xml parsing #6451

Merged
merged 1 commit into from
Jan 22, 2019
Merged

Improve CsrfBeanDefinitionParser xml parsing #6451

merged 1 commit into from
Jan 22, 2019

Conversation

ankurpathak
Copy link
Contributor

CsrfBeanDefinitionParser registers requestDataValueProcessor
if not already registered

Fixes: gh-6423

@ankurpathak ankurpathak mentioned this pull request Jan 17, 2019
Closed
rwinch
rwinch requested changes Jan 17, 2019
View reviewed changes
Copy link
Member

@rwinch rwinch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Can you please add a test?

@ankurpathak
Improve CsrfBeanDefinitionParser xml parsing
4376342 
1. CsrfBeanDefinitionParser registers requestDataValueProcessor
if not already registered
2. Created Tests in CsrfBeanDefinitionParserTests

Fixes: spring-projectsgh-6423
@ankurpathak
Copy link
Contributor Author

ankurpathak commented Jan 18, 2019 •
edited
Loading

Thanks for the PR! Can you please add a test?

@rwinch Test added.

@rwinch rwinch self-assigned this Jan 22, 2019
@rwinch rwinch added type: bug A general bug status: duplicate A duplicate of another issue Namespace labels Jan 22, 2019
@rwinch rwinch added this to the 5.2.0.M2 milestone Jan 22, 2019
@rwinch rwinch merged commit 2e70d66 into spring-projects:master Jan 22, 2019
@rwinch
Copy link
Member

rwinch commented Jan 22, 2019

Thanks this was merged into master and backported via gh-6469 gh-6470 gh-6471

@rwinch rwinch removed in: config An issue in spring-security-config Namespace labels May 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwinch rwinch rwinch approved these changes

Assignees

@rwinch rwinch

Labels
status: duplicate A duplicate of another issue type: bug A general bug
Projects
None yet
Milestone
5.2.0.M2
Development

Successfully merging this pull request may close these issues.

XML configuration with multiple security:http register multiple requestDataValueProcessor
2 participants
@ankurpathak @rwinch