OAuth2LoginSpec discovers ReactiveOAuth2AccessTokenResponseClient @bean

[aotitoola]

Fixes: gh-6477

[pivotal-issuemaster]

@d3jie Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

[pivotal-issuemaster]

@d3jie Thank you for signing the Contributor License Agreement!

[jgrandja]

Thanks for the PR @d3jie! I applied some minor polish to the commit and merged to master!
Thanks again and we look forward to your next contribution :)

[aotitoola]

Thanks @jgrandja. Can you tell me about the minor polish you applied? Maybe I can learn a thing or two. :)

[jgrandja]

Sure @d3jie

In createDefault(), you had...

ReactiveAuthenticationManager result = new OAuth2LoginReactiveAuthenticationManager(getAccessTokenResponseClient(), getOauth2UserService());

...

OidcAuthorizationCodeReactiveAuthenticationManager oidc = new OidcAuthorizationCodeReactiveAuthenticationManager(getAccessTokenResponseClient(), getOidcUserService());

I changed it to...

ReactiveOAuth2AccessTokenResponseClient<OAuth2AuthorizationCodeGrantRequest> client = getAccessTokenResponseClient();

ReactiveAuthenticationManager result = new OAuth2LoginReactiveAuthenticationManager(client, getOauth2UserService());

...

OidcAuthorizationCodeReactiveAuthenticationManager oidc = new OidcAuthorizationCodeReactiveAuthenticationManager(client, getOidcUserService());

So we re-use the client instance in both managers if the @Bean was not provided.

And inOAuth2LoginTests, I renamed the @Bean method from oAuth2AccessTokenResponseClient() to accessTokenResponseClient(). We typically don't prefix member variables or method declarations with oauth2*.

Those were the only 2 changes.

[aotitoola]

@jgrandja I can see what you did there. It didn't occur to me that I could do it this way. Many thanks. Looking forward to the next. 👍