Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reactive JwkSource Builder Parameter Type Changed the parameter type from JWT to SignedJWT Fixes: gh-6771 #6827

Merged
merged 1 commit into from
May 1, 2019

Conversation

alurysharad
Copy link
Contributor

@alurysharad alurysharad commented May 1, 2019

Reactive JwkSource Builder Parameter Type

Changed the parameter type from JWT to SignedJWT

Fixes: gh-6771

@alurysharad alurysharad marked this pull request as ready for review May 1, 2019 02:32
@jzheaux
Copy link
Contributor

jzheaux commented May 1, 2019

Thanks, @alurysharad! Will you please do one thing for me and amend your commit message to look like this:

Reactive JwkSource Builder Parameter Type

Changed the parameter type from JWT to SignedJWT

Fixes: gh-6771

Or something like that? The important pieces are that it should have a descriptive title and it should have the phrase "Fixes: gh-6771" so that the ticket gets closed when we merge this PR.

@jzheaux jzheaux self-assigned this May 1, 2019
@jzheaux jzheaux added status: duplicate A duplicate of another issue type: enhancement A general enhancement in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) labels May 1, 2019
@jzheaux jzheaux added this to the 5.2.0.M3 milestone May 1, 2019
@alurysharad alurysharad changed the title gh-6771 change Function<JWT, Flux<JWK>> to Function<SignedJWT, Flux<J… Reactive JwkSource Builder Parameter Type Changed the parameter type from JWT to SignedJWT Fixes: gh-6771 May 1, 2019
Changed the parameter type from JWT to SignedJWT

Fixes: gh-6771
@alurysharad
Copy link
Contributor Author

changed the commit message as suggested.

@jzheaux jzheaux merged commit 2850b27 into spring-projects:master May 1, 2019
@jzheaux
Copy link
Contributor

jzheaux commented May 1, 2019

Thanks, @alurysharad! This is now merged into master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) status: duplicate A duplicate of another issue type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JwkSourceReactiveJwtDecoderBuilder should be typed SignedJWT instead of JWT
2 participants