-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add @Transient to OAuth2IntrospectionAuthenticationToken #6841
Conversation
Update OAuth2IntrospectionAuthenticationToken.java
@huytn12 Thanks for the update! I have two questions:
Of course, let me know if you'd like help with either of these. |
@jzheaux Sorry for being delayed.
FAILURE: Build failed with an exception.
So I believe there's something wrong when I added new test. I'm not so sure how to fix the issue so It would great if you could help me with it. |
When I build your branch, the output shows this error: /home/jzheaux/dev/spring-projects/spring-security/config/src/test/java/org/springframework/security/config/annotation/web/configurers/oauth2/server/resource/OAuth2ResourceServerConfigurerTests.java:571: error: cannot find symbol
assertThat(result.getRequest().getSession(false)).isNull(); Does that give you enough to go off of? |
Also, @huytn12, will you please update the title and description of this PR so it reflects the issue you are solving? A title like "Add @transient to OAuth2IntrospectionAuthenticationToken" makes sense to me. The description would link to the ticket at a minimum. |
@jzheaux I updated the test and now the build failed again with different error. I look at the log file and found this
I think the the execution data for class doesn't exist. I'm not so sure how to fix this issue. Could you give me some help? |
When I compile your branch locally, I get: /home/jzheaux/dev/spring-projects/spring-security/config/src/test/java/org/springframework/security/config/annotation/web/configurers/oauth2/server/resource/OAuth2ResourceServerConfigurerTests.java:569: error: incompatible types: ResultActions cannot be converted to MvcResult
.andExpect(content().string("test-subject")); Are you able to run the build locally? Are you using an IDE? It should be able to highlight these compiler errors for you before you push. If not, then I recommend starting fresh. Get the library running in your IDE. That way, you'll be able to run the test yourself and see whether it passes or fails before pushing. |
@huytn12 is this something you are still interesting in contributing? |
@florian42 thank you, that'd be great. Please also link your PR to #6829, the related issue. |
@florian42 is this still something you'd like to contribute a PR for? |
Hi yes, didn’t get a notification. Will do it tomorrow 👍 |
No description provided.