Finer variables for OAuth2 redirectUriTemplate expansion #6900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
|
@rwinch I've managed to craft something with some assumptions, expecting feedback. |
rwinch
requested changes
Jun 4, 2019
There was a problem hiding this comment.
Thanks for the PR @zeratul021! I added review comments.
Can you also rebase off master since the class has been updated since your PR?
...ringframework/security/oauth2/client/web/DefaultOAuth2AuthorizationRequestResolverTests.java
Outdated
Show resolved
Hide resolved
...ework/security/oauth2/client/web/server/DefaultServerOAuth2AuthorizationRequestResolver.java
Show resolved
Hide resolved
...rg/springframework/security/oauth2/client/web/DefaultOAuth2AuthorizationRequestResolver.java
Show resolved
Hide resolved
...st/java/org/springframework/security/oauth2/client/registration/TestClientRegistrations.java
Outdated
Show resolved
Hide resolved
spring-projects-issues
added
the
status: waiting-for-triage
rwinch
added
in: oauth2
|
Thanks for the PR @zeratul021! This is now merged into master |
|
What was the initial reason for this change? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6239
Provided baseScheme, baseHost, basePort and basePath variables that comprise the baseUrl variable.
To avoid errors during templating, I've added all variables with empty string default.