Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add documentation for public client PKCE support #7280

Closed
wants to merge 2 commits into from
Closed

Add documentation for public client PKCE support #7280

wants to merge 2 commits into from

Conversation

sdoxsee
Copy link
Contributor

@sdoxsee sdoxsee commented Aug 19, 2019

Fixes #7279 and is related to #6485

@sdoxsee
Copy link
Contributor Author

sdoxsee commented Aug 19, 2019

@rwinch @jgrandja Public Client PKCE should definitely be documented but I'm not sure the best place for it between reactive and servlet. I've provided some basic documentation for its use but it could use some de-duplication and re-organization? Please advise. Thanks!

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Aug 19, 2019
@jgrandja jgrandja added in: docs An issue in Documentation or samples in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) and removed status: waiting-for-triage An issue we've not yet triaged labels Sep 7, 2019
@jgrandja jgrandja added this to the 5.2.0 milestone Sep 7, 2019
@jgrandja
Copy link
Contributor

Thanks for the PR @sdoxsee! This is now in master via 7dc3c8a.

FYI, I moved the content from OAuth 2.0 Login to OAuth 2.0 Client under the Authorization Code grant section. I also left out the Reactive docs since that section still needs to be written when we overhaul the Reactive docs all together.

@jgrandja jgrandja closed this Sep 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jgrandja jgrandja

Labels
in: docs An issue in Documentation or samples in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose)
Projects
None yet
Milestone
5.2.0
Development

Successfully merging this pull request may close these issues.

Add documentation for Public Client PKCE support
3 participants
@sdoxsee @jgrandja @spring-projects-issues