Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow port=0 for LDAP Servers #8139

Closed
wants to merge 1 commit into from
Closed

Allow port=0 for LDAP Servers #8139

wants to merge 1 commit into from

Conversation

jzheaux
Copy link
Contributor

@jzheaux jzheaux commented Mar 17, 2020

Fixes gh-8138

Note that a change to the XSD was necessary in order to allow for 0 in port.

Also, note that I've left one test in each LdapServerBeanDefinitionParserTests and LdapProviderBeanDefinitionParserTests that don't use port=0 to demonstrate and test default usage.

@jzheaux jzheaux requested a review from rwinch March 17, 2020 22:35
@jzheaux
Copy link
Contributor Author

jzheaux commented Apr 6, 2020

This is now merged into master via 2d8c65d and 4d99ee2

@jzheaux jzheaux closed this Apr 6, 2020
@jzheaux jzheaux self-assigned this Apr 6, 2020
@jzheaux jzheaux added in: ldap An issue in spring-security-ldap status: duplicate A duplicate of another issue type: enhancement A general enhancement labels Apr 6, 2020
@jzheaux jzheaux added this to the 5.4.0.M1 milestone Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwinch rwinch Awaiting requested review from rwinch

Assignees

@jzheaux jzheaux

Labels
in: ldap An issue in spring-security-ldap status: duplicate A duplicate of another issue type: enhancement A general enhancement
Projects
None yet
Milestone
5.4.0-M1
Development

Successfully merging this pull request may close these issues.

LDAP server configuration should support port=0
1 participant
@jzheaux