Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix userNameAttribute property case style #8171

Merged
merged 1 commit into from
Mar 23, 2020
Merged

Fix userNameAttribute property case style #8171

merged 1 commit into from
Mar 23, 2020

Conversation

komuro-hiraku
Copy link
Contributor

@komuro-hiraku komuro-hiraku commented Mar 23, 2020

Fixes gh-8169

Fix userNameAttribute property case style

@pivotal-issuemaster
Copy link

@komuro-hiraku Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-issuemaster
Copy link

@komuro-hiraku Thank you for signing the Contributor License Agreement!

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Mar 23, 2020
@eleftherias eleftherias self-assigned this Mar 23, 2020
@eleftherias eleftherias added in: docs An issue in Documentation or samples type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Mar 23, 2020
Copy link
Contributor

@eleftherias eleftherias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @komuro-hiraku!
Could you please update the second line in your commit message to say Fixes gh-8169.
This will ensure that the github issue is closed, and will link this commit to the original issue that you filed.

@komuro-hiraku
Copy link
Contributor Author

@eleftherias Thank you for your comment 😃 I fixed commit message.

@eleftherias eleftherias merged commit 10c66d2 into spring-projects:master Mar 23, 2020
@eleftherias
Copy link
Contributor

Thanks for the PR @komuro-hiraku!
This is now merged into master.

@eleftherias eleftherias added this to the 5.4.0.M1 milestone Mar 23, 2020
@komuro-hiraku komuro-hiraku deleted the gh-8169-fix-property-case-style branch April 8, 2020 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: docs An issue in Documentation or samples type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

userNameAttribute case style is different others
4 participants