Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add addFilterAfter and addFilterBefore to Kotlin DSL #8319

Merged
merged 2 commits into from
Apr 3, 2020
Merged

Add addFilterAfter and addFilterBefore to Kotlin DSL #8319

merged 2 commits into from
Apr 3, 2020

Conversation

mengelbrecht
Copy link
Contributor

Fixes gh-8316

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Apr 3, 2020
Copy link
Contributor

@eleftherias eleftherias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @mengelbrecht!
I have left one suggestion inline.

@eleftherias eleftherias added in: config An issue in spring-security-config type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Apr 3, 2020
@eleftherias eleftherias merged commit dc6b8ce into spring-projects:master Apr 3, 2020
@eleftherias
Copy link
Contributor

Thanks for the PR @mengelbrecht!
This is now merged into master.

@eleftherias eleftherias added this to the 5.4.0.M1 milestone Apr 3, 2020
@mengelbrecht mengelbrecht deleted the gh-8316 branch April 3, 2020 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: config An issue in spring-security-config type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HttpSecurityDsl does not support addFilterBefore and addFilterAfter
3 participants