Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide possibility to use custom cache to store JWK Set #8332

Closed
wants to merge 1 commit into from
Closed

Provide possibility to use custom cache to store JWK Set #8332

wants to merge 1 commit into from

Conversation

20fps
Copy link

@20fps 20fps commented Apr 6, 2020

Update according to the changes requested here #7639 by @jzheaux to have a possibility to use spring Cache to store JWK Set.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Apr 6, 2020
jzheaux
jzheaux requested changes Apr 6, 2020
View reviewed changes
Copy link
Contributor

@jzheaux jzheaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @20fps! I've left some feedback inline.

oauth2/oauth2-jose/src/main/java/org/springframework/security/oauth2/jwt/NimbusJwtDecoder.java Outdated Show resolved Hide resolved
oauth2/oauth2-jose/src/main/java/org/springframework/security/oauth2/jwt/NimbusJwtDecoder.java Outdated Show resolved Hide resolved
oauth2/oauth2-jose/src/main/java/org/springframework/security/oauth2/jwt/NimbusJwtDecoder.java Outdated Show resolved Hide resolved
oauth2/oauth2-jose/src/main/java/org/springframework/security/oauth2/jwt/NimbusJwtDecoder.java Show resolved Hide resolved
@jzheaux jzheaux mentioned this pull request Apr 6, 2020
Closed
@20fps 20fps requested a review from jzheaux April 7, 2020 10:54
jzheaux
jzheaux requested changes Apr 7, 2020
View reviewed changes
Copy link
Contributor

@jzheaux jzheaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @20fps! I've left a bit more feedback inline.

oauth2/oauth2-jose/src/main/java/org/springframework/security/oauth2/jwt/NimbusJwtDecoder.java Outdated Show resolved Hide resolved
oauth2/oauth2-jose/src/main/java/org/springframework/security/oauth2/jwt/NimbusJwtDecoder.java Outdated Show resolved Hide resolved
@20fps 20fps requested a review from jzheaux April 8, 2020 05:30
jzheaux
jzheaux requested changes Apr 8, 2020
View reviewed changes
Copy link
Contributor

@jzheaux jzheaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left just one more comment.

In light of that comment, would you also add a test that confirms that a JwtException, not a BadJwtException is thrown when using a faulty RestOperations in conjunction with a Cache?

oauth2/oauth2-jose/src/main/java/org/springframework/security/oauth2/jwt/NimbusJwtDecoder.java Outdated Show resolved Hide resolved
@jzheaux jzheaux self-assigned this Apr 8, 2020
@jzheaux jzheaux added in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Apr 8, 2020
@jzheaux jzheaux added this to the 5.4.0.M1 milestone Apr 8, 2020
@20fps 20fps requested a review from jzheaux April 9, 2020 09:11
@20fps 20fps mentioned this pull request Apr 10, 2020
Closed
@jzheaux
Copy link
Contributor

jzheaux commented Apr 10, 2020

In preparation for merging, @20fps, would you please squash your commits and format the remaining one to look something like:

Add Cache to NimbusJwtDecoderJwkSetUriBuilder

PR gh-8332

@20fps
Copy link
Author

20fps commented Apr 10, 2020

In preparation for merging, @20fps, would you please squash your commits and format the remaining one to look something like:

Add Cache to NimbusJwtDecoderJwkSetUriBuilder

PR gh-8332

np, done

jzheaux pushed a commit that referenced this pull request Apr 10, 2020
@20fps @jzheaux
Add Cache to NimbusJwtDecoderJwkSetUriBuilder
9133cc2 
PR gh-8332
jzheaux added a commit that referenced this pull request Apr 10, 2020
@jzheaux
Polish NimbusJwtDecoder
10aa974 
- Follow convention to prefix member variable references with "this."
- Reduce stack trace when IOException is thrown
- Name tests to follow conventions

Issue gh-8332
jzheaux added a commit that referenced this pull request Apr 10, 2020
@jzheaux
Add Docs
ad8c49a 
Issue gh-8332
@jzheaux
Copy link
Contributor

jzheaux commented Apr 10, 2020

Thanks, @20fps, this is now merged into master via 9133cc2. Also, I pushed a polish 10aa974 as well as a docs ad8c49a commit.

@jzheaux jzheaux closed this Apr 10, 2020
@jzheaux jzheaux mentioned this pull request Apr 10, 2020
Closed
@nicolas-teck-mox nicolas-teck-mox mentioned this pull request Jul 30, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jzheaux jzheaux jzheaux approved these changes

Assignees

@jzheaux jzheaux

Labels
in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) type: enhancement A general enhancement
Projects
None yet
Milestone
5.4.0-M1
Development

Successfully merging this pull request may close these issues.
3 participants
@20fps @jzheaux @spring-projects-issues