Upgrade Freefair AspectJ plugin to v5.0.1 #8456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `io.freefair.aspectj.post-compile-weaving` plugin v5.0.1 includes [a fix](freefair/gradle-plugins#213) that allows all tasks for `./gradlew classes` to be marked as `UP-TO-DATE` following an initial `./gradlew clean classes`. Without this fix, any compile task that is enhanced by the `io.freefair.aspectj.post-compile-weaving` plugin will incorrectly have compilation outputs configured as a _task input_, resulting in the task being out of date following a `clean compile`.
|
@bigdaz Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@pivotal-issuemaster This is an Obvious Fix |
|
@bigdaz This Pull Request contains an obvious fix. Signing the Contributor License Agreement is not necessary. |
spring-projects-issues
added
the
status: waiting-for-triage
rwinch
added
in: build
|
@bigdaz Thanks for the PR! This is now merged into master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Earlier versions of the
io.freefair.aspectj.post-compile-weavingplugin contain a bug that modifies compile tasks to incorrectly have compilation outputs configured as a task input. This results in those compile tasks not being consideredUP-TO-DATEwhen executed after an initialclean compile. This issues is likely to also affect the cacheability of these tasks.Plugin v5.0.1 includes a fix that addresses this issue. When applied to the spring-security project, all tasks for
./gradlew classeswill be marked asUP-TO-DATEfollowing an initial./gradlew clean classes.