Fix SecurityContext creation for TEST_EXECUTION #8738
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, there is support for setting up a SecurityContext after @before by using TestExecutionEvent.TEST_EXECUTION. The current implementation, however, already creates the SecurityContext in @before and just does not set it yet. This leads to issues like spring-projects#6591. For the case of @WithUserDetails, the creation of the SecurityContext already looks up a user from the repository. If the user was inserted in @before, the user is not found despite using TestExecutionEvent.TEST_EXECUTION. This commit changes the creation of the SecurityContext to happen after @before if using TestExecutionEvent.TEST_EXECUTION. Closes spring-projectsgh-6591
spring-projects-issues
added
the
status: waiting-for-triage
rwinch
added
in: test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Currently, there is support for setting up a SecurityContext after @Before by
using TestExecutionEvent.TEST_EXECUTION. The current implementation, however,
already creates the SecurityContext in @Before and just does not set it yet.
This leads to issues like #6591. For the case of @WithUserDetails, the
creation of the SecurityContext already looks up a user from the repository.
If the user was inserted in @Before, the user is not found despite using
TestExecutionEvent.TEST_EXECUTION. This can be especially problematic with
data driven test frameworks like mongoUnit which initialize the database in @Before
and drop the database after each test. In this case workarounds like described in
#6591 do not work.
This commit changes the creation of the SecurityContext to happen after @Before
if using TestExecutionEvent.TEST_EXECUTION.
Closes gh-6591.
I have submitted the CLA.