Provide a R2dbc implementation of ReactiveOuath2AuthorizedClientService #8765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
|
@ovidiupopa91 Thanks for the PR ! Overall this looks good. Spring Framework 5.3.0 GA is planned for Oct 27 so I'll review this a couple weeks beforehand and we'll merge shortly after Oct 27. Just wanted to give you an update. |
jgrandja
added
in: oauth2
jgrandja
requested changes
Oct 22, 2020
...a/org/springframework/security/oauth2/client/R2dbcReactiveOAuth2AuthorizedClientService.java
Outdated
Show resolved
Hide resolved
...a/org/springframework/security/oauth2/client/R2dbcReactiveOAuth2AuthorizedClientService.java
Outdated
Show resolved
Hide resolved
...a/org/springframework/security/oauth2/client/R2dbcReactiveOAuth2AuthorizedClientService.java
Outdated
Show resolved
Hide resolved
...a/org/springframework/security/oauth2/client/R2dbcReactiveOAuth2AuthorizedClientService.java
Outdated
Show resolved
Hide resolved
...a/org/springframework/security/oauth2/client/R2dbcReactiveOAuth2AuthorizedClientService.java
Outdated
Show resolved
Hide resolved
...a/org/springframework/security/oauth2/client/R2dbcReactiveOAuth2AuthorizedClientService.java
Outdated
Show resolved
Hide resolved
...a/org/springframework/security/oauth2/client/R2dbcReactiveOAuth2AuthorizedClientService.java
Outdated
Show resolved
Hide resolved
...a/org/springframework/security/oauth2/client/R2dbcReactiveOAuth2AuthorizedClientService.java
Outdated
Show resolved
Hide resolved
...a/org/springframework/security/oauth2/client/R2dbcReactiveOAuth2AuthorizedClientService.java
Outdated
Show resolved
Hide resolved
|
Hi @jgrandja, fixed all comments, format and checkstyle issues. |
jgrandja
requested changes
Oct 26, 2020
...nt/src/main/resources/org/springframework/security/oauth2/client/oauth2-client-schema-h2.sql
Outdated
Show resolved
Hide resolved
...a/org/springframework/security/oauth2/client/R2dbcReactiveOAuth2AuthorizedClientService.java
Outdated
Show resolved
Hide resolved
ghost
force-pushed
the
gh-7890
branch
4 times, most recently
from
5320ee1
to
56cf6eb
Compare
Implement R2dbcReactiveOuath2AuthorizedClientService which persists the Oauth2AuthorizedClient in a sql database R2dbcReactiveOuath2AuthorizedClientService is using the spring-r2dbc module to persist/load Oauth2AuthorizedClient to/from a sql database Add optional depedency to the spring-r2dbc module Add test compile dependencies to r2dbc-h2 and r2dbc-test Closes spring-projectsgh-7890
|
Thanks for the great work @ovidiupopa91 ! This is now in master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement R2dbcReactiveOuath2AuthorizedClientService which persists the
Oauth2AuthorizedClient in a sql database
Update gradle properties to use the 5.3.0-SNAPSHOT version of spring
framework (take advantage of the r2dbc integration)
Add optional depedency to the spring-r2dbc module
Add test compile dependencies to r2dbc-h2 and r2dbc-test
Closes gh-7890