Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add OpenSAML 4 support #9267

Merged
merged 2 commits into from
Mar 24, 2021
Merged

Add OpenSAML 4 support #9267

merged 2 commits into from
Mar 24, 2021

Conversation

jzheaux
Copy link
Contributor

@jzheaux jzheaux commented Dec 7, 2020

This PR adds support for OpenSAML 4.

It is in draft mode for three reasons:

  1. The build fails since it is currently requiring JDK 11, but the LDAP tests require JDK 8
  2. There are no OpenSAML4-specific tests yet
  3. I'd like some additional feedback on how the individual version-specific components are injected

@jzheaux jzheaux requested a review from rwinch December 7, 2020 20:42
@jzheaux jzheaux self-assigned this Dec 8, 2020
@jzheaux jzheaux force-pushed the gh-9095 branch 3 times, most recently from ba5d8d2 to e9ea759 Compare February 8, 2021 17:48
@jzheaux jzheaux marked this pull request as ready for review February 8, 2021 17:55
@mibo mibo mentioned this pull request Mar 18, 2021
Closed
@jzheaux jzheaux added this to the 5.5.0-RC1 milestone Mar 24, 2021
@jzheaux jzheaux added in: saml2 An issue in SAML2 modules status: duplicate A duplicate of another issue type: enhancement A general enhancement labels Mar 24, 2021
@jzheaux jzheaux merged commit d0d0a8d into spring-projects:master Mar 24, 2021
@jzheaux jzheaux deleted the gh-9095 branch March 24, 2021 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwinch rwinch Awaiting requested review from rwinch

Assignees

@jzheaux jzheaux

Labels
in: saml2 An issue in SAML2 modules status: duplicate A duplicate of another issue type: enhancement A general enhancement
Projects
None yet
Milestone
5.5.0-RC1
Development

Successfully merging this pull request may close these issues.
1 participant
@jzheaux