Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load ReactiveJwtAuthenticationConverter bean in OAuth2 Resource Server config #9699

Merged
merged 1 commit into from
Jun 15, 2021
Merged

Conversation

ThomasVitale
Copy link
Contributor

When a bean of type ReactiveJwtAuthenticationConverter is defined,
the OAuth2 Resource Server configuration will use it automatically
when no other converter is defined through the DSL.

Closes gh-9698

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Apr 30, 2021
@jzheaux jzheaux self-assigned this Apr 30, 2021
@jzheaux jzheaux added in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Apr 30, 2021
@jzheaux jzheaux added this to the 5.6.0-M1 milestone Apr 30, 2021
@jzheaux
Copy link
Contributor

jzheaux commented Apr 30, 2021

Thanks for the PR, @ThomasVitale! I've scheduled this for the 5.6 release.

@ThomasVitale
Copy link
Contributor Author

@jzheaux Nice! Thanks for checking the PR.

Copy link
Contributor

@jzheaux jzheaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @ThomasVitale! Please see my inline feedback.

@jzheaux
Copy link
Contributor

jzheaux commented Jun 7, 2021

Hi, @ThomasVitale! Are you able to apply the requested changes?

@ThomasVitale
Copy link
Contributor Author

@jzheaux sorry for the late reply. I can deliver the requested changes by the end of this week. Would that be ok?

@jzheaux
Copy link
Contributor

jzheaux commented Jun 9, 2021

Thanks for checking in, @ThomasVitale. Yes, that works great.

…r config

When a bean of type ReactiveJwtAuthenticationConverter is defined,
the OAuth2 Resource Server configuration will use it automatically
when no other converter is defined through the DSL.

Closes gh-9698
@jzheaux jzheaux added the status: duplicate A duplicate of another issue label Jun 15, 2021
@jzheaux jzheaux merged commit b44d0fb into spring-projects:main Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) status: duplicate A duplicate of another issue type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When ReactiveJwtAuthenticationConverter bean defined, use it in OAuth2 Resource Server config automatically
3 participants