Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Error Message for Invalid Properties in InMemoryUserDetailsManager #9919

Merged
merged 1 commit into from
Jun 30, 2021
Merged

Improve Error Message for Invalid Properties in InMemoryUserDetailsManager #9919

merged 1 commit into from
Jun 30, 2021

Conversation

marcusdacoregio
Copy link
Contributor

Check if the UserAttribute is null when instantiating the InMemoryUserDetailsManager using the Properties argument's constructor

Closes gh-3403

@marcusdacoregio marcusdacoregio added status: duplicate A duplicate of another issue in: core An issue in spring-security-core type: bug A general bug labels Jun 15, 2021
@marcusdacoregio marcusdacoregio added this to the 5.5.1 milestone Jun 15, 2021
@jzheaux jzheaux modified the milestones: 5.5.1, 5.6.0-M1 Jun 21, 2021
jzheaux
jzheaux requested changes Jun 28, 2021
View reviewed changes
Copy link
Contributor

@jzheaux jzheaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @marcusdacoregio! I've left some feedback inline.

core/src/main/java/org/springframework/security/provisioning/InMemoryUserDetailsManager.java Outdated Show resolved Hide resolved
core/src/main/java/org/springframework/security/provisioning/InMemoryUserDetailsManager.java Show resolved Hide resolved
@marcusdacoregio
Copy link
Contributor Author

Thanks for your review @jzheaux. I've updated the PR with your suggestions. Would you please review it again?

@jzheaux jzheaux added type: enhancement A general enhancement and removed type: bug A general bug labels Jun 30, 2021
@jzheaux jzheaux merged commit 19aa44a into spring-projects:main Jun 30, 2021
@jzheaux
Copy link
Contributor

jzheaux commented Jun 30, 2021

Thanks, @marcusdacoregio! This is now merged into main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jzheaux jzheaux jzheaux approved these changes

Assignees

@jzheaux jzheaux

Labels
in: core An issue in spring-security-core status: duplicate A duplicate of another issue type: enhancement A general enhancement
Projects
None yet
Milestone
5.6.0-M1
Development

Successfully merging this pull request may close these issues.

SEC-3204: InMemoryUserDetailsManager NullPointerException
2 participants
@marcusdacoregio @jzheaux