ReactiveVaultTemplate for the key-value backend version 2

[amrynsky]

It would be great if ReactiveVaultTemplate supports KV backend v2 similar to non-reactive version.

As a workaround, it's possible to use the current client and just add data to the path and wrap all POJO into data element but having built-in support would simplify v1->v2 migration.

[mp911de]

Feel free to submit a pull request. We initially didn't provide any higher-level API as we waited for signals how/whether the reactive API will be used.

[cantaylancapraz]

Any plan on this issue?

[tweiand]

Working on a PR for the reactive versioned/unversioned key-value operations (I can potentially work on the other operations classes after I am done with this). Seems pretty straight forward.

I am starting to collect some questions. Is this enhancement the right place to ask questions until I get a PR created?

[mp911de]

Great news, @tweiand. This is the right place to discuss design and questions.

[tweiand]

Started putting code in the enhancement-576 branch of my fork. Unit tests are created and working for V1. Have not been able to look into this for a few weeks, but, hopefully will have more time now.

Here is my current plan:

• Port the imperative code to be reactive
• Fix my current initialization of ObjectiveMapper in ReactiveVaultKeyValueAccessor
• Cleanup of code & work on JavaDocs and attribution

[mp911de]

Thanks for the update. Please note that we've upgraded Spring Javaformat which might require a rebase on your side to avoid merge conflicts caused by an updated code format.

[tweiand]

Update on this: I have integration tests for the new code and they are all passing. All JSON parsing done with WebClient, no extra ObjectMapper needed. I am not ready for a review yet, but, I am good with people starting to look at the code with the assumption that things will be changing.

Left to do before requesting review:

• Ensure code coverage & static analysis (both unit and integration tests)
• Reduce/Remove duplicate code
• Finish reviewing changes for new APIs
• Update all JavaDocs
• Rebase for Spring Javaformat

General comments so far about the repo:

• Thank you for making new tests easy!
• Some fun gems in here for dynamically creating generic Types

[tweiand]

I plan on having a MR ready for review at the end of the week.

[tweiand]

Finding time to complete this. Had other priorities pop up😀

[tweiand]

Still working on this, but, away from my laptop for two weeks.

[tweiand]

May I please get initial feedback on #807? It still needs work on the java docs and maybe some code deduplication. Wanted to get the conversation started.

[tweiand]

Hey all! Can I please get an initial review of #807 please? Once I have the initial feedback I can finish this up.

[mp911de]

I've been on vacation for the past weeks and I'll have a look in the next days.