We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
There are several unsafe places which could lead to resource (connections, byte buffers) leaks
mapOtherwise()
Mono.empty()
ClientResponse
private static <T> Mono<? extends T> mapOtherwise(ClientResponse response, String path, HttpMethod method) { if (response.statusCode() == HttpStatus.NOT_FOUND && method == HttpMethod.GET) { return Mono.empty();//<-- } return response.bodyToMono(String.class).flatMap(body -> { String error = VaultResponses.getError(body); return Mono.error(VaultResponses.buildException(response.statusCode(), path, error)); }); }
exchange()
WebClient.RequestHeadersSpec#exchangeToMono()
WebClient.ResponseSpec#toEntity()
The text was updated successfully, but these errors were encountered:
Migrate off deprecated WebClient.exchange(…)
c42c4a0
We now use exchangeToMono(…) for a safe release of the body. Closes gh-612
1e453eb
Thanks a lot, we now moved off the deprecated API.
Sorry, something went wrong.
No branches or pull requests
There are several unsafe places which could lead to resource (connections, byte buffers) leaks
mapOtherwise()
could returnMono.empty()
withoutClientResponse
consumptionhttps://github.com/spring-projects/spring-vault/blob/master/spring-vault-core/src/main/java/org/springframework/vault/core/ReactiveVaultTemplate.java#L338-L343
exchange()
.WebClient.RequestHeadersSpec#exchangeToMono()
orWebClient.ResponseSpec#toEntity()
could be used instead.The text was updated successfully, but these errors were encountered: