Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing properties in VaultCertificateRequest #682

Closed
abremora opened this issue Jan 5, 2022 · 1 comment
Closed

Add missing properties in VaultCertificateRequest #682

abremora opened this issue Jan 5, 2022 · 1 comment
Labels
status: ideal-for-contribution An issue that a contributor can help us with type: enhancement A general enhancement
Milestone
2.4.0-M1

Comments

@abremora
Copy link
Contributor

abremora commented Jan 5, 2022

Description

Several properties are missing in VaultCertificateRequest:

common_name
alt_names
ip_sans
uri_sans
other_sans           <-- missing
ttl
format               <-- missing
private_key_format   <-- missing
exclude_cn_from_sans

See: https://www.vaultproject.io/api-docs/secret/pki#generate-certificate

Solution

Update VaultCertificateRequest and its implementation for VaultPkiOperations.issueCertificate() and VaultPkiOperations.signCertificateRequest(). Especially the mapping in VaultPkiTemplate.createIssueRequest(VaultCertificateRequest certificateRequest).

Extracted issue from #477
@mp911de mp911de added the type: enhancement A general enhancement label Jan 7, 2022
abremora added a commit to abremora/spring-vault that referenced this issue Jan 8, 2022
@abremora
Add missing properties in VaultCertificateRequest
44716cb 
Fixes spring-projectsgh-682
@abremora abremora mentioned this issue Jan 8, 2022
Closed
@mp911de mp911de added the status: ideal-for-contribution An issue that a contributor can help us with label May 17, 2022
@mp911de
Copy link
Member

mp911de commented May 17, 2022

private_key_format added with #688

@mp911de mp911de added this to the 2.4.0-M1 milestone May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: ideal-for-contribution An issue that a contributor can help us with type: enhancement A general enhancement
Projects
None yet
Milestone
2.4.0-M1
Development

Successfully merging a pull request may close this issue.

Add missing properties in VaultCertificateRequest abremora/spring-vault
2 participants
@mp911de @abremora