Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add transit rewrap batch method #687

Closed
ShuP1 opened this issue Feb 28, 2022 · 0 comments
Closed

Add transit rewrap batch method #687

ShuP1 opened this issue Feb 28, 2022 · 0 comments
Labels
type: enhancement A general enhancement
Milestone
3.1.0-RC1

Comments

@ShuP1
Copy link

ShuP1 commented Feb 28, 2022 •
edited
Loading

Just a feature request to match Transit API in a better way

Vault provides batch_input on transit/%s/rewrap like encrypt and decrypt

Request and response match existing batch decrypt and encrypt one respectivly

PS: Manual implementation is ugly because VaultTransitTemplace.vaultOperations and toEncryptionResults are private
@mp911de mp911de added type: enhancement A general enhancement status: ideal-for-contribution An issue that a contributor can help us with labels Feb 28, 2022
@mp911de mp911de added this to the 3.1.0-M1 milestone Apr 19, 2023
@mp911de mp911de removed this from the 3.1.0-M1 milestone Aug 24, 2023
nbaars pushed a commit to nbaars/spring-vault that referenced this issue Sep 29, 2023
Add transit rewrap batch method
9a1e6d9 
Closes: spring-projectsgh-687
@nbaars nbaars mentioned this issue Sep 29, 2023
Closed
@mp911de mp911de removed the status: ideal-for-contribution An issue that a contributor can help us with label Oct 16, 2023
@mp911de mp911de added this to the 3.1.0-RC1 milestone Oct 16, 2023
mp911de added a commit that referenced this issue Oct 16, 2023
@mp911de
Polishing.
196d3c7 
Extract method to avoid code duplications.

Add author and since tags. Add reactive batch rewrap support.

See: gh-687
Original pull request: gh-819
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
3.1.0-RC1
Development

Successfully merging a pull request may close this issue.

Add transit rewrap batch method nbaars/spring-vault
2 participants
@mp911de @ShuP1