Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not revoke batch tokens #764

Closed
mp911de opened this issue Mar 7, 2023 · 0 comments
Closed

Do not revoke batch tokens #764

mp911de opened this issue Mar 7, 2023 · 0 comments
Labels
type: bug A general bug
Milestone
2.3.3

Comments

@mp911de
Copy link
Member

mp911de commented Mar 7, 2023

In contrast to vault service tokens, batch tokens are a JWT-like data structure that is immutable and cannot be revoked. We should not attempt revoking batch tokens.
@mp911de mp911de added the type: bug A general bug label Mar 7, 2023
@mp911de mp911de added this to the 3.0.2 milestone Mar 7, 2023
mp911de added a commit that referenced this issue Mar 7, 2023
@mp911de
Do not revoke batch tokens.
eb5c7ec 
We now track the token type and no longer attempt revoking batch tokens.
Also, refactor code duplicates to use LoginTokenUtil.

Closes gh-764
@mp911de mp911de closed this as completed in eb30607 Mar 7, 2023
mp911de added a commit that referenced this issue Mar 7, 2023
@mp911de
Do not revoke batch tokens.
fbc67a5 
We now track the token type and no longer attempt revoking batch tokens.
Also, refactor code duplicates to use LoginTokenUtil.

Closes gh-764
mp911de added a commit that referenced this issue Mar 7, 2023
@mp911de
Do not revoke batch tokens.
0b376d5 
We now track the token type and no longer attempt revoking batch tokens.
Also, refactor code duplicates to use LoginTokenUtil.

Closes gh-764
mp911de added a commit that referenced this issue Mar 7, 2023
@mp911de
Do not revoke batch tokens.
af51037 
We now track the token type and no longer attempt revoking batch tokens.
Also, refactor code duplicates to use LoginTokenUtil.

Closes gh-764
mp911de added a commit that referenced this issue Mar 7, 2023
@mp911de
Do not revoke batch tokens.
1e943b8 
We now track the token type and no longer attempt revoking batch tokens.
Also, refactor code duplicates to use LoginTokenUtil.

Closes gh-764
@mp911de mp911de modified the milestones: 3.0.2, 2.2.4, 2.3.3 Mar 7, 2023
mp911de added a commit that referenced this issue Mar 7, 2023
@mp911de
Do not revoke batch tokens.
5f28579 
We now track the token type and no longer attempt revoking batch tokens.
Also, refactor code duplicates to use LoginTokenUtil.

Closes gh-764
mp911de added a commit that referenced this issue Mar 7, 2023
@mp911de
Do not revoke batch tokens.
6c225db 
We now track the token type and no longer attempt revoking batch tokens.
Also, refactor code duplicates to use LoginTokenUtil.

Closes gh-764
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: bug A general bug
Projects
None yet
Milestone
2.3.3
Development

No branches or pull requests
1 participant
@mp911de