Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added VMSS support to Azure MSI Authentication #615

Closed
wants to merge 1 commit into from
Closed

Added VMSS support to Azure MSI Authentication #615

wants to merge 1 commit into from

Conversation

whiskeysierra
Copy link
Contributor

Fixes #614

@whiskeysierra whiskeysierra mentioned this pull request Jan 14, 2021
Closed
mp911de
mp911de requested changes Jan 14, 2021
View reviewed changes
...ng-vault-core/src/main/java/org/springframework/vault/authentication/AzureVmEnvironment.java
*/
public AzureVmEnvironment(String subscriptionId, String resourceGroupName, String vmName) {
public AzureVmEnvironment(String subscriptionId, String resourceGroupName, String vmName, String vmScaleSetName) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Care to add another constructor to retain binary compatibility? We should have both constructors, one with and one without vmScaleSet.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

mp911de pushed a commit that referenced this pull request Jan 15, 2021
@whiskeysierra @mp911de
Added VMSS support to Azure MSI Authentication
f233f30 
Fixes gh-614
Original pull request: gh-615
mp911de added a commit that referenced this pull request Jan 15, 2021
@mp911de
Polishing
873e337 
Add author and since tags.

Related ticket: gh-614
Original pull request: gh-615
mp911de pushed a commit that referenced this pull request Jan 15, 2021
@whiskeysierra @mp911de
Added VMSS support to Azure MSI Authentication
3e505f4 
Fixes gh-614
Original pull request: gh-615
mp911de added a commit that referenced this pull request Jan 15, 2021
@mp911de
Polishing
196352a 
Add author and since tags.

Related ticket: gh-614
Original pull request: gh-615
@mp911de mp911de added the type: enhancement A general enhancement label Jan 15, 2021
@mp911de mp911de added this to the 2.3.1 milestone Jan 15, 2021
@mp911de
Copy link
Member

mp911de commented Jan 15, 2021

Thank you for your contribution. That's merged, polished, and backported now.

@mp911de mp911de closed this Jan 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mp911de mp911de mp911de requested changes

Assignees
No one assigned
Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
2.3.1
Development

Successfully merging this pull request may close these issues.

VMSS support for Azure MSI Authentication
2 participants
@whiskeysierra @mp911de