Overload createKeyStore to allow password parameter to be set Fixes gh-708 #711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sodrac
commented
Jun 15, 2022
•
sodrac
commented
- Overload the CertificateBundle.createKeyStore() to allow a String password parameter to be set
- Overload the static KeystoreUtil.createKeyStore() to allow a String password parameter to be set
- Added javadoc and unit tests
- Code formatting, best practices and cosmetic changes
- Fixes Create keystore with password #708
…pring-projectsgh-708 - Overload the CertificateBundle.createKeyStore() to allow a String password parameter to be set - Overload the static KeystoreUtil.createKeyStore() to allow a String password parameter to be set - Added javadoc and unit tests - Code formatting, best practices and cosmetic changes - Fixes spring-projectsgh-708
sodrac
changed the title
sodrac
changed the title
mp911de
reviewed
Jun 15, 2022
spring-vault-core/src/main/java/org/springframework/vault/support/CertificateBundle.java
Show resolved
Hide resolved
- Overload the CertificateBundle.createKeyStore() to allow a char[] password parameter to be set - Overload the static KeystoreUtil.createKeyStore() to allow a char[] password parameter to be set - Added javadoc and unit tests - Code formatting, best practices and cosmetic changes - Fixes spring-projectsgh-708
mp911de
pushed a commit
that referenced
this pull request
Jun 24, 2022
- Overload the CertificateBundle.createKeyStore() to allow a String password parameter to be set - Overload the static KeystoreUtil.createKeyStore() to allow a String password parameter to be set - Added javadoc and unit tests - Code formatting, best practices and cosmetic changes Fixes gh-708 Original pull request: gh-711
mp911de
pushed a commit
that referenced
this pull request
Jun 24, 2022
- Overload the CertificateBundle.createKeyStore() to allow a String password parameter to be set - Overload the static KeystoreUtil.createKeyStore() to allow a String password parameter to be set - Added javadoc and unit tests - Code formatting, best practices and cosmetic changes Fixes gh-708 Original pull request: gh-711
|
Thank you for your contribution. That's merged, polished, and backported now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.