Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change JAXB dependency coordinates #1305

Closed
bclozel opened this issue Jan 4, 2023 · 1 comment
Closed

Change JAXB dependency coordinates #1305

bclozel opened this issue Jan 4, 2023 · 1 comment
Assignees
@gregturn
Labels
dependencies Pull requests that update a dependency file
Milestone
4.0.1

Comments

@bclozel
Copy link
Member

bclozel commented Jan 4, 2023

See spring-projects/spring-boot#33659 for background.

Spring WS currently depends on com.sun.xml.bind:jaxb-core; other projects in the ecosystem moved to the org.glassfish.jaxb variants instead. This causes duplicate JARs on the classpath and issues during repackaging.

Can Spring WS consider dendending on the latter?

It seems that both variants contain the same classes, with different packages. Is the application code supposed to directly refer to those classes? Maybe this change can be applied safely without any impact for developers?
@bclozel bclozel mentioned this issue Jan 4, 2023
Closed
@anbusampath anbusampath mentioned this issue Jan 4, 2023
Closed
@gregturn
Copy link
Contributor

gregturn commented Jan 4, 2023 •
edited
Loading

@bclozel com.sun.xml.bind:jaxb-impl is runtime-scoped, so there should be no expectation for any applications to directly depend upon this artifact. Instead, applications, at best, are to lean on the APIs in jakarta.xml.bind, javax.xml, etc. if they aren't simply using our APIs (which this shouldn't break).

@gregturn gregturn added this to the 4.0.1 milestone Jan 4, 2023
@gregturn gregturn self-assigned this Jan 4, 2023
@gregturn gregturn added the dependencies Pull requests that update a dependency file label Jan 4, 2023
gregturn added a commit that referenced this issue Jan 4, 2023
@gregturn
gh-1305 - Prepare branch
3f838f1
gregturn added a commit that referenced this issue Jan 4, 2023
@gregturn
Migrate to Glassfish JAXB.
55ff813 
Resolves #1305.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gregturn gregturn

Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
4.0.1
Development

No branches or pull requests
2 participants
@bclozel @gregturn