Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use bulk operation addAll instead of iteration. #1336

Closed
wants to merge 1 commit into from
Closed

Use bulk operation addAll instead of iteration. #1336

wants to merge 1 commit into from

Conversation

hduelme
Copy link
Contributor

@hduelme hduelme commented Feb 12, 2023

Using addAll() makes the code easier to read and could provide a small speedup. So it should be used instead of an iteration.

@gregturn gregturn changed the title use bulk operation addAll instead of iteration Use bulk operation addAll instead of iteration. Apr 5, 2023
@gregturn gregturn added this to the 4.0.3 milestone Apr 5, 2023
@gregturn gregturn self-assigned this Apr 5, 2023
@gregturn gregturn closed this in 151ff28 Apr 5, 2023
@gregturn
Copy link
Contributor

gregturn commented Apr 5, 2023

Thanks @hduelme!

gregturn pushed a commit that referenced this pull request Apr 5, 2023
@hduelme @gregturn
Use List.addAll() instead of iteration.
5a24548 
Resolves #1336.
@markreesmoj markreesmoj mentioned this pull request Oct 23, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@gregturn gregturn

Labels
polishing type: task
Projects
None yet
Milestone
4.0.3
Development

Successfully merging this pull request may close these issues.
2 participants
@hduelme @gregturn