feat(core): Make @AsyncOperation.Headers.Header#value optional

fixes #791
springwolf · Jun 10, 2024 · 0bd6528 · 0bd6528
1 parent dc6e019
commit 0bd6528
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 2 deletions.
diff --git a/...olf-core/src/main/java/io/github/springwolf/core/asyncapi/annotations/AsyncOperation.java b/...olf-core/src/main/java/io/github/springwolf/core/asyncapi/annotations/AsyncOperation.java
@@ -54,7 +54,7 @@
 
             String description() default "";
 
-            String value();
+            String value() default "";
         }
     }
 }
diff --git a/...in/java/io/github/springwolf/core/asyncapi/scanners/common/utils/AsyncAnnotationUtil.java b/...in/java/io/github/springwolf/core/asyncapi/scanners/common/utils/AsyncAnnotationUtil.java
@@ -74,6 +74,7 @@ private static List<String> getHeaderValues(
             List<AsyncOperation.Headers.Header> value, StringValueResolver resolver) {
         return value.stream()
                 .map(AsyncOperation.Headers.Header::value)
+                .filter(StringUtils::hasText)
                 .map(resolver::resolveStringValue)
                 .sorted()
                 .toList();

diff --git a/...ava/io/github/springwolf/core/asyncapi/scanners/common/utils/AsyncAnnotationUtilTest.java b/...ava/io/github/springwolf/core/asyncapi/scanners/common/utils/AsyncAnnotationUtilTest.java
@@ -50,11 +50,23 @@ void getAsyncHeaders(Class<?> classWithOperationBindingProcessor) throws NoSuchM
         SchemaObject headers = AsyncAnnotationUtil.getAsyncHeaders(operation, resolver);
         assertEquals("TestSchema", headers.getTitle());
         assertEquals("header-descriptionResolved", headers.getDescription());
-        assertTrue(headers.getProperties().containsKey("headerResolved"));
+        assertTrue(
+                headers.getProperties().containsKey("headerResolved"),
+                headers.getProperties() + " does not contain key 'headerResolved'");
         SchemaObject headerResolved = (SchemaObject) headers.getProperties().get("headerResolved");
         assertEquals("string", headerResolved.getType());
         assertEquals("valueResolved", headerResolved.getExamples().get(0));
         assertEquals("descriptionResolved", headerResolved.getDescription());
+
+        assertTrue(
+                headers.getProperties().containsKey("headerWithoutValueResolved"),
+                headers.getProperties() + " does not contain key 'headerWithoutValueResolved'");
+        SchemaObject headerWithoutValueResolved =
+                (SchemaObject) headers.getProperties().get("headerWithoutValueResolved");
+        assertEquals("string", headerWithoutValueResolved.getType());
+        assertTrue(headerWithoutValueResolved.getExamples().isEmpty());
+        assertTrue(headerWithoutValueResolved.getEnumValues().isEmpty());
+        assertEquals("descriptionResolved", headerWithoutValueResolved.getDescription());
     }
 
     @Test
@@ -215,6 +227,9 @@ private static class ClassWithOperationBindingProcessor {
                                                     @AsyncOperation.Headers.Header(
                                                             name = "header",
                                                             value = "value",
+                                                            description = "description"),
+                                                    @AsyncOperation.Headers.Header(
+                                                            name = "headerWithoutValue",
                                                             description = "description")
                                                 })))
         @TestOperationBindingProcessor.TestOperationBinding()
@@ -259,6 +274,9 @@ private static class ClassWithAbstractOperationBindingProcessor {
                                                     @AsyncOperation.Headers.Header(
                                                             name = "header",
                                                             value = "value",
+                                                            description = "description"),
+                                                    @AsyncOperation.Headers.Header(
+                                                            name = "headerWithoutValue",
                                                             description = "description")
                                                 })))
         @TestAbstractOperationBindingProcessor.TestOperationBinding()