Fix: Serialize StringSchema without error (#159)

springwolf · Mar 31, 2023 · 7578fd1 · 7578fd1
1 parent b243fc3
commit 7578fd1
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/...olf-core/src/main/java/io/github/stavshamir/springwolf/schemas/DefaultSchemasService.java b/...olf-core/src/main/java/io/github/stavshamir/springwolf/schemas/DefaultSchemasService.java
@@ -96,7 +96,7 @@ private void buildExampleAsString(String k, Schema schema) {
 
     private void deserializeExampleToMap(String k, Schema schema) {
         try {
-            schema.setExample(objectMapper.readValue((String) schema.getExample(), Map.class));
+            schema.setExample(objectMapper.readValue((String) schema.getExample(), Object.class));
         } catch (IOException e) {
             log.error("Failed to convert example object of {} to map", schema.getName());
         }

diff --git a/...core/src/test/java/io/github/stavshamir/springwolf/schemas/DefaultSchemasServiceTest.java b/...core/src/test/java/io/github/stavshamir/springwolf/schemas/DefaultSchemasServiceTest.java
@@ -38,6 +38,12 @@ public void string() throws IOException, JSONException {
                 .isEqualTo("String");
 
         assertNotNull(schemasService.getDefinitions().get(modelName));
+
+        Schema schema = schemasService.getDefinitions().get(modelName);
+        String example = objectMapper.writeValueAsString(schema.getExample());
+        String expectedExample = "\"string\"";
+
+        assertThat(example).isEqualTo(expectedExample);
     }
 
     @Test
@@ -49,7 +55,6 @@ public void simpleObject() throws IOException, JSONException {
 
         Schema schema = schemasService.getDefinitions().get(modelName);
         String example = objectMapper.writeValueAsString(schema.getExample());
-
         String expectedExample = jsonResource(EXAMPLES_PATH + "/simple-foo.json");
 
         JSONAssert.assertEquals(expectedExample, example, JSONCompareMode.STRICT);