Chore/javax dependency cleanup #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
removed javax.xml.bind:jaxb-api excluded groupid javax.validation
tvahrst
commented
Jun 5, 2023
timonback
approved these changes
Jun 5, 2023
|
This is great. Thank you for digging through the dependencies (and fixing the left over NotNull import) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR explicitly declares a
io.swagger.core.v3:swagger-core-jakartadependency instead ofio.swagger.core.v3:swagger-core.The latter one came transiently via swagger-inflector and is now excluded. This change allowed it to remove the dependency of
javax.xml.bind:jaxb-api.swagger-inflector also pulls transiently the 'older'
io.swagger:swagger-coredependency (v1.6.9, other group-id, other package-names) which unfortunately cannot be excluded, because swagger-inflector needs some utility classes from this dependency (io.swagger.util.Json)This necessary old swagger-core dependency has itself a dependency to javax.validation, which should not be part of the springwolf dependency tree because springwolf changed to SpringBoot 3.x and jakarta. So, the groupId javax.validation is explicitly excluded from the transient deps of swagger-inflector.
There was one usage of javax.validation.NotNull in
AsyncAPIwhich seems to be accidently defined. This annotation was changed to lombok.NonNull (like all other methods inAsyncAPI)