-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat] Added Kotlinx Serialization support #656
[feat] Added Kotlinx Serialization support #656
Conversation
✅ Deploy Preview for springwolf-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this implementation as it is a lot more compact and an add-on module seems appropriate.
Can you add a (small) test case for useFqn=true (the name field is sufficient)?
29ea6f3
to
642ddc1
Compare
@timonback done. I will keep iterating over next PRs, but I think it's good enough to go, at least as a |
...addons/kotlinx_serialization_model_converter/converter/KotlinxSerializationModelConverter.kt
Outdated
Show resolved
Hide resolved
Hi @ctasada, we had a look at the changes and like it a lot more than the one that you have shown us before. We like to see:
We created ctasada#3 as as suggestion for both and postpone the release till Wednesday (27.3.) to give you some time to review the suggestion. Tests can be refactored later, but we would like to make the production code simpler. From our side it would be sufficient to just merge the PR ctasada#3 and then we can merge this PR without the need for further changes for the march release. |
Added basic support for KotlinX Serialization classes. This new module serializes Kotlin `@Serializable` classes respecting the `@SerialName` annotation and types.
…alizationModelConverter and add suggestion for more fine grained tests Co-authored-by: Timon Back <timonback@users.noreply.github.com>
1866a0a
to
008943c
Compare
@sam0r040 @timonback I merged the suggested improvements, fixed the Hopefully we are good to go |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great @ctasada and looking forward to the next improvement to move it beyond the beta status.
Added basic support for KotlinX Serialization classes.
This new module serializes Kotlin
@Serializable
classes respecting the@SerialName
annotation and types.Solves #589