Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ethers v6 #147

Merged
merged 2 commits into from
Apr 6, 2023
Merged

Support ethers v6 #147

merged 2 commits into from
Apr 6, 2023

Conversation

freeatnet
Copy link
Contributor

@freeatnet freeatnet commented Feb 26, 2023

This PR introduces compatibility with ethers v6. It's a bit hacky, but it works.

Copy link
Member

@w4ll3 w4ll3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi again, can you please rebase with latest merged changes?

packages/siwe/package.json Show resolved Hide resolved
* loosen peerDependencies on siwe

* set up ethers5 and ethers6 devDependencies to enable testing with both versions

* allow test runner to select ethers 5 or 6

* create a compatibility layer that exports the right functions based on whether we are using ethers v5 or v6
@freeatnet
Copy link
Contributor Author

@w4ll3 updated!

@w4ll3 w4ll3 merged commit e12cd8d into spruceid:main Apr 6, 2023
@freeatnet freeatnet deleted the feat/support-ethers-v6 branch June 26, 2023 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants