Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CC-23635 Added optimisations to handle product bundle on cart page. #199

Closed
wants to merge 7 commits into from
Closed

CC-23635 Added optimisations to handle product bundle on cart page. #199

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
53b3cb7
CC-23635 integrate performance fix
artem-png Mar 22, 2023
7c56a7d
CC-23635 revert lock changes
artem-png Mar 24, 2023
c15a68e
CC-23635 revert lock changes
artem-png Mar 24, 2023
06c52da
CC-23635 update composer dependencies
artem-png Mar 24, 2023
1e26079
CC-23635 revert spryker-feature/prices upgrade
artem-png Mar 24, 2023
4e5ac56
CC-23635 spryker/price-cart-connector version adjusted
artem-png Mar 27, 2023
a4b59af
CC-23635 update lock file
artem-png Mar 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"spryker-feature/agent-assist": "^202212.0",
"spryker-feature/alternative-products": "dev-master as 202304.0",
"spryker-feature/availability-notification": "^202212.0",
"spryker-feature/cart": "^202212.0",
"spryker-feature/cart": "dev-master as 202304.0",
"spryker-feature/catalog": "^202212.0",
"spryker-feature/category-management": "dev-master as 202304.0",
"spryker-feature/checkout": "^202212.0",
Expand All @@ -41,7 +41,7 @@
"spryker-feature/prices": "^202212.0",
"spryker-feature/product": "dev-master as 202304.0",
"spryker-feature/product-barcode": "^202212.0",
"spryker-feature/product-bundles": "^202212.0",
"spryker-feature/product-bundles": "dev-master as 202304.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please adjust spryker/price-cart-connector version.

"spryker-feature/product-groups": "^202212.0",
"spryker-feature/product-labels": "dev-master as 202304.0",
"spryker-feature/product-lists": "dev-master as 202304.0",
Expand Down Expand Up @@ -142,7 +142,7 @@
"spryker/orders-rest-api": "^4.11.0",
"spryker/payment-cart-connector": "^1.0.1",
"spryker/payments-rest-api": "^1.1.1",
"spryker/price-cart-connector": "^6.8.0",
"spryker/price-cart-connector": "^6.9.0",
"spryker/price-product-volumes-rest-api": "^1.1.0",
"spryker/product-alternative-product-label-connector": "^1.1.1",
"spryker/product-attributes-rest-api": "^1.0.0",
Expand Down
82 changes: 50 additions & 32 deletions composer.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 12 additions & 0 deletions src/Pyz/Zed/PriceCartConnector/PriceCartConnectorConfig.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@

namespace Pyz\Zed\PriceCartConnector;

use Generated\Shared\Transfer\ItemTransfer;
use Spryker\Zed\PriceCartConnector\PriceCartConnectorConfig as SprykerPriceCartConnectorConfig;

class PriceCartConnectorConfig extends SprykerPriceCartConnectorConfig
Expand All @@ -15,4 +16,15 @@ class PriceCartConnectorConfig extends SprykerPriceCartConnectorConfig
* @var bool
*/
protected const IS_ZERO_PRICE_ENABLED_FOR_CART_ACTIONS = false;

/**
* @return list<string>
*/
public function getItemFieldsForIdentifier(): array
{
return array_merge(parent::getItemFieldsForIdentifier(), [
ItemTransfer::SKU,
ItemTransfer::QUANTITY,
]);
}
}