Removal of Python 3.6 #455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
JulianMaurin
approved these changes
Jul 20, 2022
Co-authored-by: Julian Maurin <julian.maurin.perso@pm.me>
|
Yea. Let's. |
marcinsulikowski
added a commit
to marcinsulikowski/freezegun
that referenced
this pull request
Sep 14, 2022
PR spulec#455 removed support for Python 3.6 so we remove it from tox.ini. This should allow us to use Python 3.7+-only features, like `asyncio.run`.
marcinsulikowski
added a commit
to marcinsulikowski/freezegun
that referenced
this pull request
Sep 14, 2022
To avoid this warning:
freezegun/tests/test_asyncio.py:12: DeprecationWarning: There is no current event loop
asyncio.get_event_loop().run_until_complete(frozen_coroutine())
on Pyuthon 3.10+, we modify tests to use `asyncio.run` instead of
`asyncio.get_event_loop().run_until_complete`, which [1] recommends:
asyncio.get_event_loop()
(...)
Consider also using the asyncio.run() function instead of using
lower level functions to manually create and close an event loop.
Deprecated since version 3.10: Deprecation warning is emitted
if there is no running event loop. In future Python releases,
this function will be an alias of get_running_loop().
`asyncio.run` has been added in Python 3.7 but we no longer support 3.6
(see spulec#455) so we can use it.
[1] https://docs.python.org/3/library/asyncio-eventloop.html#asyncio.get_event_loop
marcinsulikowski
added a commit
to marcinsulikowski/freezegun
that referenced
this pull request
Sep 14, 2022
PR spulec#455 removed support for Python 3.6 so we remove it from `tox.ini`. This should allow us to use Python 3.7+-only features, like `asyncio.run`.
marcinsulikowski
added a commit
to marcinsulikowski/freezegun
that referenced
this pull request
Sep 14, 2022
To avoid this warning:
freezegun/tests/test_asyncio.py:12: DeprecationWarning: There is no current event loop
asyncio.get_event_loop().run_until_complete(frozen_coroutine())
on Python 3.10+, we modify tests to use `asyncio.run` instead of
`asyncio.get_event_loop().run_until_complete`, which [1] recommends:
asyncio.get_event_loop()
(...)
Consider also using the asyncio.run() function instead of using
lower level functions to manually create and close an event loop.
Deprecated since version 3.10: Deprecation warning is emitted
if there is no running event loop. In future Python releases,
this function will be an alias of get_running_loop().
`asyncio.run` has been added in Python 3.7 but we no longer support 3.6
(see spulec#455) so we can use it.
[1] https://docs.python.org/3/library/asyncio-eventloop.html#asyncio.get_event_loop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://endoflife.date/python