PR: Improve UI/UX of the Run plugin configuration widgets

binder/environment.yml

@@ -50,7 +50,7 @@ dependencies:
 - setuptools >=49.6.0
 - sphinx >=0.6.6
 - spyder-kernels >=3.0.0b6,<3.0.0b7
-- superqt >=0.6.1,<1.0.0
+- superqt >=0.6.2,<1.0.0
 - textdistance >=4.2.0
 - three-merge >=0.1.1
 - watchdog >=0.10.3

requirements/main.yml

@@ -46,7 +46,7 @@ dependencies:
   - setuptools >=49.6.0
   - sphinx >=0.6.6
   - spyder-kernels >=3.0.0b6,<3.0.0b7
-  - superqt >=0.6.1,<1.0.0
+  - superqt >=0.6.2,<1.0.0
   - textdistance >=4.2.0
   - three-merge >=0.1.1
   - watchdog >=0.10.3

setup.py

@@ -247,7 +247,7 @@ def run(self):
     'setuptools>=49.6.0',
     'sphinx>=0.6.6',
     'spyder-kernels>=3.0.0b6,<3.0.0b7',
-    'superqt>=0.6.1,<1.0.0',
+    'superqt>=0.6.2,<1.0.0',
     'textdistance>=4.2.0',
     'three-merge>=0.1.1',
     'watchdog>=0.10.3',

spyder/api/widgets/menus.py

@@ -295,12 +295,17 @@ def _add_missing_actions(self):
 
         self._unintroduced_actions = {}
 
-    def render(self):
+    def render(self, force=False):
         """
         Create the menu prior to showing it. This takes into account sections
         and location of menus.
+
+        Parameters
+        ----------
+        force: bool, optional
+            Whether to force rendering the menu.
         """
-        if self._dirty:
+        if self._dirty or force:
             self.clear()
             self._add_missing_actions()
 

spyder/app/tests/conftest.py

@@ -250,7 +250,6 @@ def generate_run_parameters(mainwindow, filename, selected=None,
     file_run_params = StoredRunConfigurationExecutor(
         executor=executor,
         selected=selected,
-        display_dialog=False
     )
 
     return {file_uuid: file_run_params}

spyder/app/tests/test_mainwindow.py

@@ -438,9 +438,6 @@ def test_get_help_ipython_console_dot_notation(main_window, qtbot, tmpdir):
     main_window.editor.load(test_file)
     code_editor = main_window.editor.get_focus_widget()
 
-    run_parameters = generate_run_parameters(main_window, test_file)
-    CONF.set('run', 'last_used_parameters', run_parameters)
-
     # Run test file
     qtbot.keyClick(code_editor, Qt.Key_F5)
     qtbot.wait(500)
@@ -483,9 +480,6 @@ def test_get_help_ipython_console_special_characters(
     main_window.editor.load(test_file)
     code_editor = main_window.editor.get_focus_widget()
 
-    run_parameters = generate_run_parameters(main_window, test_file)
-    CONF.set('run', 'last_used_parameters', run_parameters)
-
     # Run test file
     qtbot.keyClick(code_editor, Qt.Key_F5)
     qtbot.wait(500)
@@ -726,7 +720,12 @@ def test_runconfig_workdir(main_window, qtbot, tmpdir):
 
     exec_uuid = str(uuid.uuid4())
     ext_exec_conf = ExtendedRunExecutionParameters(
-        uuid=exec_uuid, name='TestConf', params=exec_conf)
+        uuid=exec_uuid,
+        name="TestConf",
+        params=exec_conf,
+        default=False,
+        file_uuid=None,
+    )
 
     ipy_dict = {ipyconsole.NAME: {
         ('py', RunContext.File): {'params': {exec_uuid: ext_exec_conf}}
@@ -809,7 +808,12 @@ def test_dedicated_consoles(main_window, qtbot):
 
     exec_uuid = str(uuid.uuid4())
     ext_exec_conf = ExtendedRunExecutionParameters(
-        uuid=exec_uuid, name='TestConf', params=exec_conf)
+        uuid=exec_uuid,
+        name="TestConf",
+        params=exec_conf,
+        default=False,
+        file_uuid=None,
+    )
 
     ipy_dict = {ipyconsole.NAME: {
         ('py', RunContext.File): {'params': {exec_uuid: ext_exec_conf}}
@@ -918,7 +922,12 @@ def test_shell_execution(main_window, qtbot, tmpdir):
 
     exec_uuid = str(uuid.uuid4())
     ext_exec_conf = ExtendedRunExecutionParameters(
-        uuid=exec_uuid, name='TestConf', params=exec_conf)
+        uuid=exec_uuid,
+        name="TestConf",
+        params=exec_conf,
+        default=False,
+        file_uuid=None,
+    )
 
     ipy_dict = {external_terminal.NAME: {
         (ext, RunContext.File): {'params': {exec_uuid: ext_exec_conf}}
@@ -946,8 +955,10 @@ def test_shell_execution(main_window, qtbot, tmpdir):
 
 
 @flaky(max_runs=3)
-@pytest.mark.skipif(sys.platform.startswith('linux'),
-                    reason="Fails frequently on Linux")
+@pytest.mark.skipif(
+    sys.platform.startswith('linux') and running_in_ci(),
+    reason="Fails frequently on Linux"
+)
 @pytest.mark.order(after="test_debug_unsaved_function")
 def test_connection_to_external_kernel(main_window, qtbot):
     """Test that only Spyder kernels are connected to the Variable Explorer."""
@@ -993,10 +1004,6 @@ def test_connection_to_external_kernel(main_window, qtbot):
         "print(2 + 1)"
     )
 
-    file_path = main_window.editor.get_current_filename()
-    run_parameters = generate_run_parameters(main_window, file_path)
-    CONF.set('run', 'last_used_parameters', run_parameters)
-
     # Start running
     with qtbot.waitSignal(shell.executed):
         qtbot.mouseClick(main_window.run_button, Qt.LeftButton)
@@ -1161,10 +1168,6 @@ def test_run_cython_code(main_window, qtbot):
     file_path = osp.join(LOCATION, 'pyx_script.pyx')
     main_window.editor.load(file_path)
 
-    # --- Set run options for this file ---
-    run_parameters = generate_run_parameters(main_window, file_path)
-    CONF.set('run', 'last_used_parameters', run_parameters)
-
     # Run file
     qtbot.keyClick(code_editor, Qt.Key_F5)
 
@@ -1188,10 +1191,6 @@ def test_run_cython_code(main_window, qtbot):
     file_path = osp.join(LOCATION, 'pyx_lib_import.py')
     main_window.editor.load(file_path)
 
-    # --- Set run options for this file --
-    run_parameters = generate_run_parameters(main_window, file_path)
-    CONF.set('run', 'last_used_parameters', run_parameters)
-
     # Run file
     qtbot.keyClick(code_editor, Qt.Key_F5)
 
@@ -1436,9 +1435,6 @@ def test_run_code(main_window, qtbot, tmpdir):
     # Get a reference to the namespace browser widget
     nsb = main_window.variableexplorer.current_widget()
 
-    run_parameters = generate_run_parameters(main_window, filepath)
-    CONF.set('run', 'last_used_parameters', run_parameters)
-
     # ---- Run file ----
     with qtbot.waitSignal(shell.executed):
         qtbot.keyClick(code_editor, Qt.Key_F5)
@@ -1847,9 +1843,6 @@ def test_maximize_minimize_plugins(main_window, qtbot):
         exclude=[Plugins.Editor, Plugins.IPythonConsole]
     )
     qtbot.mouseClick(max_button, Qt.LeftButton)
-
-    run_parameters = generate_run_parameters(main_window, test_file)
-    CONF.set('run', 'last_used_parameters', run_parameters)
     qtbot.mouseClick(main_window.run_button, Qt.LeftButton)
 
     assert not plugin_3.get_widget().get_maximized_state()
@@ -3295,10 +3288,6 @@ def test_preferences_empty_shortcut_regression(main_window, qtbot):
     code_editor = main_window.editor.get_focus_widget()
     code_editor.set_text(u'print(0)\n#%%\nprint(ññ)')
 
-    fname = main_window.editor.get_current_filename()
-    run_parameters = generate_run_parameters(main_window, fname)
-    CONF.set('run', 'last_used_parameters', run_parameters)
-
     with qtbot.waitSignal(shell.executed):
         qtbot.keyClick(code_editor, Qt.Key_Return, modifier=Qt.ShiftModifier)
     qtbot.waitUntil(lambda: u'print(0)' in shell._control.toPlainText())
@@ -3602,10 +3591,6 @@ def test_varexp_rename(main_window, qtbot, tmpdir):
     # Get a reference to the namespace browser widget
     nsb = main_window.variableexplorer.current_widget()
 
-    # --- Set run options for this file ---
-    run_parameters = generate_run_parameters(main_window, filepath)
-    CONF.set('run', 'last_used_parameters', run_parameters)
-
     # ---- Run file ----
     with qtbot.waitSignal(shell.executed):
         qtbot.mouseClick(main_window.run_button, Qt.LeftButton)
@@ -3673,10 +3658,6 @@ def test_varexp_remove(main_window, qtbot, tmpdir):
     # Get a reference to the namespace browser widget
     nsb = main_window.variableexplorer.current_widget()
 
-    # --- Set run options for this file ---
-    run_parameters = generate_run_parameters(main_window, filepath)
-    CONF.set('run', 'last_used_parameters', run_parameters)
-
     # ---- Run file ----
     with qtbot.waitSignal(shell.executed, timeout=SHELL_TIMEOUT):
         qtbot.mouseClick(main_window.run_button, Qt.LeftButton)
@@ -3757,10 +3738,6 @@ def test_runcell_edge_cases(main_window, qtbot, tmpdir):
         lambda: shell.spyder_kernel_ready and shell._prompt_html is not None,
         timeout=SHELL_TIMEOUT)
 
-    fname = main_window.editor.get_current_filename()
-    run_parameters = generate_run_parameters(main_window, fname)
-    CONF.set('run', 'last_used_parameters', run_parameters)
-
     # call runcell
     with qtbot.waitSignal(shell.executed):
         qtbot.mouseClick(main_window.run_cell_and_advance_button,
@@ -3810,10 +3787,6 @@ def test_runcell_pdb(main_window, qtbot):
     code_editor = main_window.editor.get_focus_widget()
     code_editor.set_text(code)
 
-    fname = main_window.editor.get_current_filename()
-    run_parameters = generate_run_parameters(main_window, fname)
-    CONF.set('run', 'last_used_parameters', run_parameters)
-
     # Start debugging
     with qtbot.waitSignal(shell.executed, timeout=SHELL_TIMEOUT):
         qtbot.mouseClick(debug_button, Qt.LeftButton)
@@ -3858,10 +3831,6 @@ def test_runcell_cache(main_window, qtbot, debug):
     code_editor = main_window.editor.get_focus_widget()
     code_editor.set_text(code)
 
-    fname = main_window.editor.get_current_filename()
-    run_parameters = generate_run_parameters(main_window, fname)
-    CONF.set('run', 'last_used_parameters', run_parameters)
-
     if debug:
         # Start debugging
         with qtbot.waitSignal(shell.executed):
@@ -4112,10 +4081,6 @@ def test_runcell_after_restart(main_window, qtbot):
     code_editor = main_window.editor.get_focus_widget()
     code_editor.set_text(code)
 
-    fname = main_window.editor.get_current_filename()
-    run_parameters = generate_run_parameters(main_window, fname)
-    CONF.set('run', 'last_used_parameters', run_parameters)
-
     # Restart Kernel
     widget = main_window.ipyconsole.get_widget()
     with qtbot.waitSignal(shell.sig_prompt_ready, timeout=10000):
@@ -4435,10 +4400,6 @@ def test_run_unsaved_file_multiprocessing(main_window, qtbot):
     code_editor.set_text(text)
     # This code should run even on windows
 
-    fname = main_window.editor.get_current_filename()
-    run_parameters = generate_run_parameters(main_window, fname)
-    CONF.set('run', 'last_used_parameters', run_parameters)
-
     # Start running
     qtbot.mouseClick(main_window.run_button, Qt.LeftButton)
 
@@ -5515,10 +5476,6 @@ def test_func():
         timeout=SHELL_TIMEOUT)
     control = main_window.ipyconsole.get_widget().get_focus_widget()
 
-    fname = main_window.editor.get_current_filename()
-    run_parameters = generate_run_parameters(main_window, fname)
-    CONF.set('run', 'last_used_parameters', run_parameters)
-
     main_window.editor.get_widget().update_run_focus_file()
     qtbot.wait(2000)
 
@@ -5554,10 +5511,6 @@ def crash_func():
         timeout=SHELL_TIMEOUT)
     control = main_window.ipyconsole.get_widget().get_focus_widget()
 
-    fname = main_window.editor.get_current_filename()
-    run_parameters = generate_run_parameters(main_window, fname)
-    CONF.set('run', 'last_used_parameters', run_parameters)
-
     main_window.editor.get_widget().update_run_focus_file()
     qtbot.wait(2000)
 
@@ -5707,10 +5660,6 @@ def test_debug_unsaved_function(main_window, qtbot):
     code_editor = main_window.editor.get_focus_widget()
     code_editor.set_text('def foo():\n    print(1)')
 
-    fname = main_window.editor.get_current_filename()
-    run_parameters = generate_run_parameters(main_window, fname)
-    CONF.set('run', 'last_used_parameters', run_parameters)
-
     main_window.editor.get_widget().update_run_focus_file()
     qtbot.wait(2000)
 
@@ -5757,10 +5706,6 @@ def test_out_runfile_runcell(main_window, qtbot):
         code_editor = main_window.editor.get_focus_widget()
         code_editor.set_text(code)
 
-        fname = main_window.editor.get_current_filename()
-        run_parameters = generate_run_parameters(main_window, fname)
-        CONF.set('run', 'last_used_parameters', run_parameters)
-
         with qtbot.waitSignal(shell.executed):
             qtbot.mouseClick(main_window.run_cell_button,
                              Qt.LeftButton)
@@ -5809,10 +5754,6 @@ def test_print_frames(main_window, qtbot, tmpdir, thread):
     debugger = main_window.debugger.get_widget()
     frames_browser = debugger.current_widget().results_browser
 
-    # --- Set run options for this file ---
-    run_parameters = generate_run_parameters(main_window, str(p))
-    CONF.set('run', 'last_used_parameters', run_parameters)
-
     # Click the run button
     qtbot.mouseClick(main_window.run_button, Qt.LeftButton)
     qtbot.wait(1000)
@@ -6496,6 +6437,7 @@ def test_PYTHONPATH_in_consoles(main_window, qtbot, tmp_path,
 
 @flaky(max_runs=10)
 @pytest.mark.skipif(sys.platform == 'darwin', reason="Fails on Mac")
+@pytest.mark.order(before='test_shell_execution')
 def test_clickable_ipython_tracebacks(main_window, qtbot, tmp_path):
     """
     Test that file names in IPython console tracebacks are clickable.
@@ -6526,8 +6468,6 @@ def test_clickable_ipython_tracebacks(main_window, qtbot, tmp_path):
     qtbot.keyClicks(code_editor, '1/0')
 
     # Run test file
-    run_parameters = generate_run_parameters(main_window, test_file)
-    CONF.set('run', 'last_used_parameters', run_parameters)
     qtbot.mouseClick(main_window.run_button, Qt.LeftButton)
     qtbot.wait(500)
 

spyder/app/utils.py

@@ -187,6 +187,15 @@ def qt_message_handler(msg_type, msg_log_context, msg_string):
         # This is shown when expanding/collpasing folders in the Files plugin
         # after spyder-ide/spyder#
         "QFont::setPixelSize: Pixel size <= 0 (0)",
+        # These warnings are shown uncollapsing CollapsibleWidget
+        "QPainter::begin: Paint device returned engine == 0, type: 2",
+        "QPainter::save: Painter not active",
+        "QPainter::setPen: Painter not active",
+        "QPainter::setWorldTransform: Painter not active",
+        "QPainter::setOpacity: Painter not active",
+        "QFont::setPixelSize: Pixel size <= 0 (-3)",
+        "QPainter::setFont: Painter not active",
+        "QPainter::restore: Unbalanced save/restore",
     ]
     if msg_string not in BLACKLIST:
         print(msg_string)  # spyder: test-skip
@@ -358,6 +367,16 @@ def create_window(WindowClass, app, splash, options, args):
     main.show()
     main.post_visible_setup()
 
+    # Add a reference to the main window so it can be accessed from anywhere.
+    #
+    # Notes
+    # -----
+    # * This should be used to get main window properties (such as width,
+    #   height or position) that other widgets can need to position relative to
+    #   it.
+    # * **DO NOT** use it to access other plugins functionality through it.
+    app.main_window = main
+
     if main.console:
         main.console.start_interpreter(namespace={})
         main.console.set_namespace_item('spy', Spy(app=app, window=main))

spyder/config/main.py

@@ -643,7 +643,6 @@
         ('run', [
             'breakpoints',
             'configurations',
-            'defaultconfiguration',
             'default/wdir/fixed_directory',
             'last_used_parameters',
             'parameters'

spyder/dependencies.py

@@ -74,7 +74,7 @@
 SETUPTOOLS_REQVER = '>=49.6.0'
 SPHINX_REQVER = '>=0.6.6'
 SPYDER_KERNELS_REQVER = '>=3.0.0b6,<3.0.0b7'
-SUPERQT_REQVER = '>=0.6.1,<1.0.0'
+SUPERQT_REQVER = '>=0.6.2,<1.0.0'
 TEXTDISTANCE_REQVER = '>=4.2.0'
 THREE_MERGE_REQVER = '>=0.1.1'
 WATCHDOG_REQVER = '>=0.10.3'