PR: Limit sphinx version to <7.4.0 to prevent bug with splash screen on Windows
#22370
Conversation
ccordoba12
changed the title
<7.4.0 to prevent bug with splash screen on Windows
|
@mrclary, I think we should include this fix in rc2 to test the installers before the final release. Do you agree? |
|
Yes. Do you want me to include the changes to remove |
Ok, please do that too. |
There was a problem hiding this comment.
Looks good to me, thanks @mrclary!
Note: The size of the Windows and Linux installers decreased by almost 100Mb by using matplotlib-base!
| @@ -43,6 +43,7 @@ def setup_page(self): | |||
| features_group = QGroupBox(_("Additional features")) | |||
| math_box = self.create_checkbox(_("Render mathematical equations"), | |||
| 'math') | |||
| # ??? Do we want to increase minimum sphinx requirement for Spyder? | |||
There was a problem hiding this comment.
Yeah, this is a good idea. Perhaps increasing it to Sphinx 4 or 5 would be better, but I don't know enough about it to take an informed decision.
There was a problem hiding this comment.
I don't know enough either. It may be best to leave the lower limit where it currently is, at least for now.
…avoid installing unnecessary pyside and qt6 packages. tornado is already a dependent of ipykernel and jupyter-client.
There was a problem hiding this comment.
Thanks @mrclary ! I gave this PR Windows installer a local check and seems like the splash screen is working as expected 👍
If understood correctly, the sphinx dependency version constraint is only required for Windows right? If so, could it be worthy to only limit the Sphinx version on Windows? Also, could it be worthy to create a follow up issue to hopefully remove the upper constraint when the specific reason why this is happening is discovered, right @ccordoba12 @mrclary ?
I think it's easier to leave that constraint for all OSes for now. Then in 6.0.1 we can try to commit a proper fix.
Good idea. Could you create one and tag it for 6.0.1? Thanks! |
|
Created #22374. Merging this to proceed with the release |
Description of Changes
Limit
sphinxversion to <7.4.0. <=7.4.0 causes issue with Spyder's splash screen.Also, only use
matplotlib-basefor installer runtime environment. This prevents installing unnecessarypysideandqt6-mainpackages.Issue(s) Resolved
Fixes #22353