Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Don't expose SpyderPlugin and SpyderPluginWidget as part of the public API #22377

Merged
merged 2 commits into from
Aug 23, 2024

Conversation

ccordoba12
Copy link
Member

@ccordoba12 ccordoba12 commented Aug 23, 2024

Description of Changes

  • Since the migration to the new API is now complete, there are no internal plugins that rely on those classes anymore. So it's better not to support them in Spyder 6 (otherwise we wouldn't notice when we break them).
  • Also, bump API version to 1.0.0 to try to keep it stable.

Issue(s) Resolved

Fixes #

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct:

Since the migration to the new API is complete, there are no internal
plugins that rely on those classes anymore. So it's better not to
support them for Spyder 6 (otherwise we wouldn't notice when we break
them).
This means that from now on we'll try to keep it as stable as possible.
@ccordoba12 ccordoba12 added this to the v6.0.0 milestone Aug 23, 2024
@ccordoba12 ccordoba12 self-assigned this Aug 23, 2024
@pep8speaks
Copy link

Hello @ccordoba12! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 97:1: E402 module level import not at top of file
Line 98:1: E402 module level import not at top of file

@ccordoba12 ccordoba12 merged commit 6cb9e98 into spyder-ide:master Aug 23, 2024
14 checks passed
@ccordoba12 ccordoba12 deleted the dont-expose-old-api branch August 23, 2024 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants