-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR: Update workflows to accommodate GitHub deprecation of macos-12 runners (CI) #22696
Conversation
@ccordoba12, macos-13 runner does not have Miniconda preinstalled, causing the tests to fail. I don't know if we want to install that in addition to micromamba or change from |
e745853
to
603a098
Compare
Ok, that's not good.
There's no need to use the |
6eceaeb
to
dacddac
Compare
Leaving this for 6.0.3 (or maybe even 6.0.4) to not affect the minimal Mac version supported by our installers in the 6.0 cycle. |
Update hard-coded CI miniconda base location
dacddac
to
9c00dd8
Compare
@ccordoba12, I recommend including this in 6.0.3 and merge as soon as is convenient as we are now experiencing the brown out for macOS 12. I don't think this will immediately impact any macOS 12 users, since this should only impact our CI environment and restricting macOS in our installer does not work yet. |
Yep, I noticed that in another PR and I think it's a good idea. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mrclary!
@meeseeksdev please backport to 6.x |
…Hub deprecation of macos-12 runners (CI)
… GitHub deprecation of macos-12 runners (CI)) (#22848)
See actions/runner-images#10721