Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Update workflows to accommodate GitHub deprecation of macos-12 runners (CI) #22696

Merged
merged 2 commits into from
Nov 4, 2024

Conversation

mrclary
Copy link
Contributor

@mrclary mrclary commented Oct 19, 2024

@mrclary mrclary self-assigned this Oct 19, 2024
@mrclary mrclary marked this pull request as draft October 19, 2024 18:26
@mrclary
Copy link
Contributor Author

mrclary commented Oct 21, 2024

@ccordoba12, macos-13 runner does not have Miniconda preinstalled, causing the tests to fail. I don't know if we want to install that in addition to micromamba or change from setup-micromamba to setup-miniconda.

@mrclary mrclary force-pushed the macos-12-deprecation branch from e745853 to 603a098 Compare October 21, 2024 17:27
@ccordoba12
Copy link
Member

ccordoba12 commented Oct 21, 2024

macos-13 runner does not have Miniconda preinstalled, causing the tests to fail.

Ok, that's not good.

I don't know if we want to install that in addition to micromamba or change from setup-micromamba to setup-miniconda

There's no need to use the setup-miniconda action. What's necessary is to set the CONDA env var to a certain directory in the Mac workflow file and then install Miniconda in $CONDA (I think it's better to do that in install.sh).

@mrclary mrclary force-pushed the macos-12-deprecation branch from 6eceaeb to dacddac Compare October 21, 2024 19:35
@mrclary mrclary marked this pull request as ready for review October 21, 2024 21:25
@mrclary mrclary requested a review from ccordoba12 October 21, 2024 21:25
@ccordoba12 ccordoba12 changed the title PR: Update workflows to accommodate GitHub deprecation of macos-12 runners PR: Update workflows to accommodate GitHub deprecation of macos-12 runners (CI) Oct 21, 2024
@ccordoba12 ccordoba12 added this to the v6.0.3 milestone Oct 21, 2024
@ccordoba12
Copy link
Member

Leaving this for 6.0.3 (or maybe even 6.0.4) to not affect the minimal Mac version supported by our installers in the 6.0 cycle.

@ccordoba12 ccordoba12 modified the milestones: v6.0.3, v6.0.4 Oct 31, 2024
@mrclary mrclary force-pushed the macos-12-deprecation branch from dacddac to 9c00dd8 Compare November 4, 2024 20:14
@mrclary
Copy link
Contributor Author

mrclary commented Nov 4, 2024

@ccordoba12, I recommend including this in 6.0.3 and merge as soon as is convenient as we are now experiencing the brown out for macOS 12. I don't think this will immediately impact any macOS 12 users, since this should only impact our CI environment and restricting macOS in our installer does not work yet.

@ccordoba12 ccordoba12 modified the milestones: v6.0.4, v6.0.3 Nov 4, 2024
@ccordoba12
Copy link
Member

I recommend including this in 6.0.3 and merge as soon as is convenient as we are now experiencing the brown out for macOS 12.

Yep, I noticed that in another PR and I think it's a good idea.

Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mrclary!

@ccordoba12 ccordoba12 merged commit 5ce099e into spyder-ide:master Nov 4, 2024
27 checks passed
@ccordoba12
Copy link
Member

@meeseeksdev please backport to 6.x

meeseeksmachine pushed a commit to meeseeksmachine/spyder that referenced this pull request Nov 4, 2024
@mrclary mrclary deleted the macos-12-deprecation branch November 4, 2024 22:56
ccordoba12 pushed a commit that referenced this pull request Nov 4, 2024
… GitHub deprecation of macos-12 runners (CI)) (#22848)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants